From: Kay Sievers <kay.sievers@vrfy.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: kobject_set_name() uses GFP_KERNEL
Date: Wed, 6 May 2009 15:17:52 +0200 [thread overview]
Message-ID: <ac3eb2510905060617l708a5024p8f67a90d447a3cae@mail.gmail.com> (raw)
In-Reply-To: <1241540502.2987.22.camel@localhost.localdomain>
On Tue, May 5, 2009 at 18:21, Marcel Holtmann <marcel@holtmann.org> wrote:
> all the users of kobject_set_name() which includes dev_set_name() are
> allocating their memory for the device name with GFP_KERNEL. It is not a
> big deal since device_add() does the same. However it is not obvious and
> I ran into an issue in the Bluetooth stack where I was setting the
> device name from a context that can't sleep. If this behavior is on
> purpose, we better add an extra comment in the documentation.
It's the entire driver core and kobjects which use GFP_KERNEL, so it
just "happened" for that function too, I guess.
If it helps to documents that, where should it be added? Maybe you can
just send a patch?
Thanks,
Kay
prev parent reply other threads:[~2009-05-06 13:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 16:21 Marcel Holtmann
2009-05-06 13:17 ` Kay Sievers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac3eb2510905060617l708a5024p8f67a90d447a3cae@mail.gmail.com \
--to=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®