From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759966AbZEMM6r (ORCPT ); Wed, 13 May 2009 08:58:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755489AbZEMM6i (ORCPT ); Wed, 13 May 2009 08:58:38 -0400 Received: from mail-fx0-f158.google.com ([209.85.220.158]:43615 "EHLO mail-fx0-f158.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755415AbZEMM6i (ORCPT ); Wed, 13 May 2009 08:58:38 -0400 MIME-Version: 1.0 In-Reply-To: <1242217342.9974.10.camel@localhost.localdomain> References: <20090509143742.GA27663@kroah.com> <20090511175626.GA4758@kroah.com> <1242074517.6624.183.camel@moss-terrapins.epoch.ncsc.mil> <1242132344.31807.48.camel@localhost.localdomain> <1242142528.31807.80.camel@localhost.localdomain> <1242168913.6711.9.camel@poy> <1242217342.9974.10.camel@localhost.localdomain> From: Kay Sievers Date: Wed, 13 May 2009 14:58:18 +0200 Message-ID: Subject: Re: [patch 00/13] devtmpfs patches To: Stephen Smalley Cc: "David P. Quigley" , Greg KH , linux-kernel@vger.kernel.org, Greg KH , Jan Blunck , James Morris , Eric Paris , David Howells Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 13, 2009 at 14:22, Stephen Smalley wrote: > I think you'll actually need to switch credentials around the entire > sequence starting from vfs_path_lookup() and going through the > vfs_mknod() call in order to avoid any denials from vfs_path_lookup, > vfs_mkdir (via create_path), and vfs_mknod. > > Then the same issue applies to devtmpfs_delete_node() to prevent unlink > denials against the current process when a node is removed, similarly > wrapping everything from the vfs_path_lookup() through the final > delete_path() call. Ok, good, will do that. Anything like this to keep in mind when creating/removing simple subdirectories? Thanks, Kay