From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757028AbZEVLnS (ORCPT ); Fri, 22 May 2009 07:43:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751584AbZEVLnD (ORCPT ); Fri, 22 May 2009 07:43:03 -0400 Received: from mail-fx0-f158.google.com ([209.85.220.158]:64567 "EHLO mail-fx0-f158.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376AbZEVLnB convert rfc822-to-8bit (ORCPT ); Fri, 22 May 2009 07:43:01 -0400 MIME-Version: 1.0 In-Reply-To: <20090416.155643.06066521.davem@davemloft.net> References: <20090327.172743.30040617.davem@davemloft.net> <1239898912.17211.7.camel@poy> <20090416.155643.06066521.davem@davemloft.net> From: Kay Sievers Date: Fri, 22 May 2009 13:42:42 +0200 Message-ID: Subject: Re: sparc: struct device - replace bus_id with dev_name(), dev_set_name() To: David Miller Cc: greg@kroah.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 17, 2009 at 00:56, David Miller wrote: >>> > The name size limit is gone, there is no BUS_ID_SIZE thing anymore in >>> > the driver core. BUS_ID_SIZE should go away in the 2.6.30 timeframe. >>> > >>> > Could you please convert/remove BUS_ID_SIZE value from: >>> >   drivers/net/gianfar.h:   char    phy_bus_id[BUS_ID_SIZE]; >>> >   drivers/net/ucc_geth.h:  char phy_bus_id[BUS_ID_SIZE]; >>> >   drivers/net/pasemi_mac.h:        char    phy_id[BUS_ID_SIZE]; >>> >   include/linux/phy.h:#define MII_BUS_ID_SIZE      (BUS_ID_SIZE - 3) >>> >   include/linux/phy.h:     char bus_id[BUS_ID_SIZE]; >>> > >>> > Or let me know how you want to convert it, so I can do it? >>> >>> Thanks a lot Kay, I'll look into these cases and take care >>> of it. >> >> This moves the 20 into the netdevice header, we need to get rid >> of the driver core define now, otherwise people start adding new >> code using it, and we want to finish this thankless job finally. :) > > I was working on fixing this properly Kay, please be patient. > > I'll have it killed off in net-next-2.6 soon enough. Hey David, just a quick check, to make sure we are prepared when 2.6.31 opens. Any updates regarding the BUS_ID_SIZE conversion? Thanks, Kay