From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753214AbZHFATj (ORCPT ); Wed, 5 Aug 2009 20:19:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752740AbZHFATi (ORCPT ); Wed, 5 Aug 2009 20:19:38 -0400 Received: from mail-fx0-f228.google.com ([209.85.220.228]:36151 "EHLO mail-fx0-f228.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752406AbZHFATi convert rfc822-to-8bit (ORCPT ); Wed, 5 Aug 2009 20:19:38 -0400 MIME-Version: 1.0 In-Reply-To: <20090806000659.GA22754@kroah.com> References: <20090805171513.GA10443@kroah.com> <9b2b86520908051355o79699e99ke045b635c6b443ad@mail.gmail.com> <20090806000659.GA22754@kroah.com> From: Kay Sievers Date: Thu, 6 Aug 2009 02:19:23 +0200 Message-ID: Subject: Re: [PATCH] Driver Core: devtmpfs - kernel-maintained tmpfs-based /dev To: Greg KH Cc: Alan Jenkins , linux-kernel@vger.kernel.org, Jan Blunck , gregkh@suse.de, Harald Hoyer , Scott James Remnant Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 6, 2009 at 02:06, Greg KH wrote: > On Wed, Aug 05, 2009 at 09:55:49PM +0100, Alan Jenkins wrote: >> > +                   err = vfs_mkdir(nd.path.dentry->d_inode, >> > +                                   dentry, 0775); >> >> Is there a typo here?  I think the mode should be 0755.   0755 is used >> below, and that does fit better with the 0600 mode for device nodes. > > Yeah, I think you are correct.  Kay, any objection to me making this > change? No, sure no objection. It sounds right to use 0755. I was just waiting if more things to fix come up. :) Thanks, Kay