Re: [PATCH] firmware class: export nowait to userspace

[Kay Sievers <kay.sievers@vrfy.org>]

On Fri, Mar 12, 2010 at 05:46, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Fri, 2010-03-12 at 05:21 +0100, Kay Sievers wrote:
>> The firmware_class already always exports a TIMEOUT= value, right? If
>> this is the case, it should be set to 0, I guess.
>
> Yes and no. It is exported, but typically it will be 60 seconds. And
> even in this case it makes sense to eventually time out when userspace
> is not responding.

Ok, I didn't expect the async version to time out. Sounds fine then.

>> Sounds fine to have a flag like this, while "NOWAIT" is, I guess, a
>> pretty bad name from the event perspective. This name might make sense
>> for the called kernel function, but not so much for a firmware loader
>> instruction.
>
> Yeah, I can agree with that. How about "ASYNC" or so? It needs to
> distinguish between "I'm going to wait for this please respond" and "I'm
> not really waiting, please let me now when you can".

Yeah, sounds fine to me.

Thanks,
Kay