From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44AF2C433FE for ; Tue, 9 Nov 2021 15:46:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3066E61156 for ; Tue, 9 Nov 2021 15:46:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229955AbhKIPtO (ORCPT ); Tue, 9 Nov 2021 10:49:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235926AbhKIPtM (ORCPT ); Tue, 9 Nov 2021 10:49:12 -0500 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C277C061767 for ; Tue, 9 Nov 2021 07:46:26 -0800 (PST) Received: by mail-ot1-x336.google.com with SMTP id o15-20020a9d410f000000b0055c942cc7a0so8777427ote.8 for ; Tue, 09 Nov 2021 07:46:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kali.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Nhd1cXLoARHfuxijxW1CC8tXdTo48PjAHCwKpZq0Ohs=; b=IKxmNKTX0BIWoiJVskOWy25AW2N8zqTy4fIP0lluheBJPb6RR1HGWEcAHuwHK3XXKN nQFDNMBxdgoBMZ+zfGlDzEFGyZVsZFTU9hhONQ+Yn+3HIgl0qlMdLyRHuMbYRYDyHf0v TiDtEXaMz3rSGQLrg8ez3XZs+rszck4hArdyX5U0D3YELE4JsUMpnh5JJ7C3/CuyMs/r 54vcG13G//Zju+1iQhAWmTogb8mWB7XfGblWrJFFMT7PO6hka0efOdxIxJyTvnHYMAGS qlphXdeiSYmFj9I6WwLQA+3zxKXUo8CMUH4gpUxzADZIsjcahm5O12FMBbotMKTxiXRb Yg0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Nhd1cXLoARHfuxijxW1CC8tXdTo48PjAHCwKpZq0Ohs=; b=S8+ML/0cvDIjsB38YBC3/Nv9ST+70l5S7HO+TDwRdQH/fzojdBKgG9oaD/UBXuIpL2 owvo//DnRW7NuqXVr3CwFNEzYLSj45sSmVxPCvT3xeAARechS9sKxkxXZ1HoSlOp2wBu bLC8uUzT11BYW1BGa9xH6exvxnI9WIXy2rUdhf12UC2601piU4Gq+zdBlJOL/F/Vww4K 6tZiyOiI2T+JXO30EkDSvj4kVELjW1ktSDA7hcFiUlVtELBm+9xteDVRgk1fSlkkLVnI 8nYgKrDKzLB+5LLMnwpiuVL78VLNuynGTJrwUa7cq8cl8KCu64AjDaPYLScMdk212ipO Deiw== X-Gm-Message-State: AOAM531YOTioNpHo/Sytz6frwuQQepZwYN3SsoHvWd+Qo8GZXLpIJVsu B5lcV0lioz7M7vs+S/aAbiqb4g== X-Google-Smtp-Source: ABdhPJwMddWy/2opZdv1H0HcP66DI5B4SNXuxuecEiT10xIXb7rTcbNEsMS/6lJop5oEBqi3iRisPA== X-Received: by 2002:a9d:6f09:: with SMTP id n9mr6847374otq.357.1636472785577; Tue, 09 Nov 2021 07:46:25 -0800 (PST) Received: from [192.168.11.48] (cpe-173-173-107-246.satx.res.rr.com. [173.173.107.246]) by smtp.gmail.com with ESMTPSA id v66sm7430632oib.18.2021.11.09.07.46.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Nov 2021 07:46:25 -0800 (PST) Message-ID: Date: Tue, 9 Nov 2021 09:46:23 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v3 0/5] Refactor thermal pressure update to avoid code duplication Content-Language: en-US To: Lukasz Luba Cc: Thara Gopinath , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, sudeep.holla@arm.com, will@kernel.org, catalin.marinas@arm.com, linux@armlinux.org.uk, gregkh@linuxfoundation.org, rafael@kernel.org, viresh.kumar@linaro.org, amitk@kernel.org, daniel.lezcano@linaro.org, amit.kachhap@gmail.com, bjorn.andersson@linaro.org, agross@kernel.org References: <20211103161020.26714-1-lukasz.luba@arm.com> <3cba148a-7077-7b6b-f131-dc65045aa348@arm.com> <9d533b6e-a81c-e823-fa6f-61fdea92fa65@kali.org> <74ea027b-b213-42b8-0f7d-275f3b84712e@linaro.org> <74603569-2ff1-999e-9618-79261fdb0ee4@kali.org> <59054c90-c1cd-85bf-406e-579df668d7b4@linaro.org> <2c54dbbd-2ecb-fb76-fa9f-9752f429c20e@linaro.org> <97e93876-d654-0a89-dce1-6fe1189345e2@kali.org> From: Steev Klimaszewski In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/9/21 2:29 AM, Lukasz Luba wrote: > Hi Steev, > > That's interesting what you've done with Rockchip RK3399. > I would like to reproduce your experiment on my RockPI 4B v1.3. > Could you tell me how you to add this boost frequency that you have > mentioned in some previous emails? > > I want to have similar setup to yours and I'll check all the subsystems > involved in the decision making process for triggering this boost freq. > > Thank you for your support. > > Regards, > Lukasz Hi Lukasz, It was actually something that Armbian had been doing as an overlay for their setup, and I thought, why does it need to be an overlay, when we could simply hide it behind turbo-mode so that if users want to overclock, they simply echo 1 and if it's unstable or cooling/power isn't enough, they can echo 0 or leave it off (boost defaults to off) - so that being said: I apply this patch https://gitlab.com/kalilinux/build-scripts/kali-arm/-/blob/master/patches/pinebook-pro/pbp-5.14/rk3399-opp-overclock-2GHz-turbo-mode.patch which adds the 1.5GHz for little cores and 2GHz for the big to the rk3399 dtsi To enable at boot time, I simply have "echo 1 > /sys/devices/system/cpu/cpufreq/boost" in my /etc/rc.local  And to disable, simply echo 0 in there (it defaults to 0 so it's off and most users won't know it exists.) I'm pretty sure this is "abusing" turbo-mode, but it works well enough... Hope that helps, -- steev