From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6311241C8C for ; Thu, 2 Apr 2026 04:11:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775103107; cv=none; b=WOxktOl2RgoX+vEQktlLz7GfhIvQ30hoyWBn4e1cSBbi9yIGM/9Lw7k/5rOI02Gc3qTzSM/hEz1dUDsCSbMRSbWwzoQN4AtnXr2ABTxzvuWWPDp03/j+D12CigT3UwqR+jgG0FniORXIKtY8bb02uLUm9b6HUxi5xAKfwy870ds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775103107; c=relaxed/simple; bh=gjN6IPgIWc9pLcP7hLhiuTVm/LCpSc0jwe3SrPuO8QE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k6YelgcQa/Vyv+0YsI/0Bm5W/77+A07OZ8vOR+4qRpEewXKoKaEbmHbeZhPmc9UFNEsJRUIrg4XevzFOkXHclufcim5HkVRxRpZWorH1tYF5K4CnKLTZKGo0SdhO385v/dEnMsG2aeOv+bKqxTTMjrZ3T33g02N0JcpLUCjL3ik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Cy90xzIh; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Cy90xzIh" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gjN6IPgIWc9pLcP7hLhiuTVm/LCpSc0jwe3SrPuO8QE=; b=Cy90xzIhfidaefZ3g7xz0/UTnC wFQ3ETt2ilQ9TJjGIysb64yV7cu/DWdIujOZ4I4+1yUxK8t0FS6ogeGNNS94HoymPGIlq5IjoOKep XixJKYms5xZ+/vf1DuYKVtS0Bd9NggGGYNHLWavxeIJVV7RMdkZiywQ8b/gOT9MIqfaYeyPAg8+6Y e+EESsgBVQy93/Ez+a2vs8hoM8MYthikBKYUdPUq90F+DL8s8eOgMy0T6G8TCAZwD41GR3dOC8BKV /xvVege9scxNVgghIvKQrRsT5EMiVsMlJTKoFt3Gca9ZlfcYXwoKT+evyHSjmHxWgWsUUw6BtncIk hj7PM+qQ==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1w89Ot-0000000BYOc-18Az; Thu, 02 Apr 2026 04:11:23 +0000 Date: Thu, 2 Apr 2026 05:11:23 +0100 From: Matthew Wilcox To: David Carlier Cc: Barry Song <21cnbao@gmail.com>, Kairui Song , David Hildenbrand , Chris Li , Andrew Morton , Kemeng Shi , Nhat Pham , Baoquan He , Youngjun Park , NeilBrown , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3] mm/page_io: use sio->len for PSWPIN accounting in sio_read_complete() Message-ID: References: <20260330071229.14614-1-devnexen@gmail.com> <20260401074753.238053-1-devnexen@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260401074753.238053-1-devnexen@gmail.com> On Wed, Apr 01, 2026 at 08:47:53AM +0100, David Carlier wrote: > sio_read_complete() uses sio->pages to account global PSWPIN vm events, > but sio->pages tracks the number of bvec entries (folios), not base > pages. Since you're messing with this file anyway, do you want to submit a third patch to rename swap_iocb->pages to ->bvecs?