From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B956C43334 for ; Fri, 8 Jul 2022 15:44:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238757AbiGHPoS (ORCPT ); Fri, 8 Jul 2022 11:44:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233930AbiGHPoQ (ORCPT ); Fri, 8 Jul 2022 11:44:16 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A15111163 for ; Fri, 8 Jul 2022 08:44:16 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id B8C85660191B; Fri, 8 Jul 2022 16:44:13 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1657295054; bh=C9e8etBg/94GadxYv8MdzYOOgITsxTDLOb+J9ydTXUI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bogbx1s19Ny4+aonY/okvHFLJtBHdmRxtkEfd1xOkVJPG/pCRbiXuDyiQZt+3sEpv 0MP0rJ7WxFIvF6O0LTlWTmpnVQtAcA0pQYxjzyquj3HcBm9CmVi+wOarpRO4oZ1zhv h3OnP1zB6fnKVqj2lDInyqfDRRKtqTdG75rQ33ZuAO7DjhxtkX71Zke4XqBfXPf6pk /xZK7Y8sm+CRVgvv0ozMkwpUa2cLD/HfuG/HhYHT2TmnB1U2RSxr3qYxkBOzVdT0z1 /Y6udKRV95q1mMx15ceWrXvR/rsAYvS5abCrFCsGK4WiI/pYTMAZ0K4w8fT0Y/DBhR vpasooaBoS8VA== Message-ID: Date: Fri, 8 Jul 2022 17:44:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] ASoC: mediatek: mt8186: Remove condition with no effect Content-Language: en-US To: Jiaxin Yu , Zhongjun Tan , lgirdwood@gmail.com, broonie@kernel.org, perex@perex.c, tiwai@suse.com, matthias.bgg@gmail.com, tanzhongjun@coolpad.com, colin.king@intel.com Cc: alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220708024651.42999-1-hbut_tan@163.com> <503a71aa95b8e4b75eb7e9e5de03a013f5155036.camel@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <503a71aa95b8e4b75eb7e9e5de03a013f5155036.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 08/07/22 12:19, Jiaxin Yu ha scritto: > On Fri, 2022-07-08 at 10:01 +0200, AngeloGioacchino Del Regno wrote: >> Il 08/07/22 04:46, Zhongjun Tan ha scritto: >>> From: Zhongjun Tan >>> >>> Remove condition with no effect >>> >>> Signed-off-by: Zhongjun Tan >>> --- >>> sound/soc/mediatek/mt8186/mt8186-dai-adda.c | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/sound/soc/mediatek/mt8186/mt8186-dai-adda.c >>> b/sound/soc/mediatek/mt8186/mt8186-dai-adda.c >>> index db71b032770d..6be6d4f3b585 100644 >>> --- a/sound/soc/mediatek/mt8186/mt8186-dai-adda.c >>> +++ b/sound/soc/mediatek/mt8186/mt8186-dai-adda.c >>> @@ -295,8 +295,6 @@ static int mtk_adda_pad_top_event(struct >>> snd_soc_dapm_widget *w, >>> case SND_SOC_DAPM_PRE_PMU: >>> if (afe_priv->mtkaif_protocol == >>> MTKAIF_PROTOCOL_2_CLK_P2) >>> regmap_write(afe->regmap, AFE_AUD_PAD_TOP, >>> 0x39); >>> - else if (afe_priv->mtkaif_protocol == >>> MTKAIF_PROTOCOL_2) >>> - regmap_write(afe->regmap, AFE_AUD_PAD_TOP, >>> 0x31); >> >> I think that this needs some clarification from MediaTek: was 0x31 a >> typo here? >> >> Regards, >> Angelo >> > Hi Angelo, > > This patch can be accepted. The 0x31 is not typo, the logic of this > code is not concise enough. > > Thanks, > Jiaxin.Yu Thank you for the clarification. In this case: Reviewed-by: AngeloGioacchino Del Regno Cheers! > >>> else >>> regmap_write(afe->regmap, AFE_AUD_PAD_TOP, >>> 0x31); >>> break; >> >> >