From: Mark Brown <broonie@kernel.org>
To: James Calligeros <jcalligeros99@gmail.com>
Cc: "David Rhodes" <david.rhodes@cirrus.com>,
"Richard Fitzgerald" <rf@opensource.cirrus.com>,
"Martin Povišer" <povik+lin@cutebit.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
asahi@lists.linux.dev, linux-sound@vger.kernel.org,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: codecs: cs42l84: set up PLL for more sample rates
Date: Tue, 10 Mar 2026 18:51:25 +0000 [thread overview]
Message-ID: <ac417b14-dcdd-4e67-b1c0-b41ff1e22fc3@sirena.org.uk> (raw)
In-Reply-To: <20260307-cs42l84-rates-v1-1-1c55a5673031@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]
On Sat, Mar 07, 2026 at 10:44:18AM +1000, James Calligeros wrote:
> Fill out more PLL config parameters in the PLL config lookup
> table, and advertise the corresponding sample rates to userspace.
> This enables 44.1, 88.2, 176.4 and 192 kHz output and input.
> static const struct cs42l84_pll_params pll_ratio_table[] = {
> + { 2822400, 1, 0, 0x40, 0x000000, 0x03, 0x10, 11289600},
> { 3072000, 1, 0, 0x40, 0x000000, 0x03, 0x10, 12288000},
> + { 5644800, 1, 0, 0x40, 0x000000, 0x03, 0x10, 11289600},
> { 6144000, 1, 1, 0x40, 0x000000, 0x03, 0x10, 12288000},
> + { 11289600, 0, 0, 0, 0, 0, 0, 11289600},
> { 12288000, 0, 0, 0, 0, 0, 0, 12288000},
> { 24576000, 1, 3, 0x40, 0x000000, 0x03, 0x10, 12288000},
> };
These are adding 44.1kHz based rates with a new value for MCLK (the
final value in each entry). Those values are read with a switch
statement in cs42l84_pll_config but that only has an entry for 24.576MHz
for some reason, that won't match 112.896MHz and will just leave the
pll_mclk_f with whatever value it had before. Don't we need a new case
statement there for the new MCLK?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-03-10 18:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 0:44 James Calligeros
2026-03-10 18:51 ` Mark Brown [this message]
2026-03-11 10:52 ` James Calligeros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac417b14-dcdd-4e67-b1c0-b41ff1e22fc3@sirena.org.uk \
--to=broonie@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=david.rhodes@cirrus.com \
--cc=jcalligeros99@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=povik+lin@cutebit.org \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®