From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B492AC433DF for ; Tue, 25 Aug 2020 13:16:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A21720639 for ; Tue, 25 Aug 2020 13:16:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="hwc0ZlwI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727078AbgHYNQw (ORCPT ); Tue, 25 Aug 2020 09:16:52 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:58166 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726149AbgHYNQs (ORCPT ); Tue, 25 Aug 2020 09:16:48 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 07PDGao5036885; Tue, 25 Aug 2020 08:16:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1598361396; bh=N96D9x+cfIc6e+cmK+tbORS+cMhXtDcJGJh2vSD1HVM=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=hwc0ZlwIAArDgY+jcQb7oQndBlwK8+IYrRiK4TSycH8VnKeNOsVNow6LvoRFbRZY+ inPZL9g1LKHVfBuwYalVw5hEdsUAwxQ+UAquGhpCCvPZx7iztfLtirwOyUck8Wel9k SoWBQszbIi8TBfWQEE9/oVF9T9jwireqh0FLapik= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 07PDGZ8S124249 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 25 Aug 2020 08:16:36 -0500 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 25 Aug 2020 08:16:35 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 25 Aug 2020 08:16:35 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 07PDGXLR033440; Tue, 25 Aug 2020 08:16:34 -0500 Subject: Re: [REGRESSION] omapdrm/N900 display broken To: Aaro Koskinen , Laurent Pinchart , ML dri-devel CC: Tony Lindgren , , References: <20200728181412.GA49617@darkstar.musicnaut.iki.fi> <660b2fe1-343d-b83e-11d2-5a5eb530b83f@ti.com> <448c1441-2cac-44ef-95ef-bb28b512297b@ti.com> <20200823162625.GC4313@darkstar.musicnaut.iki.fi> From: Tomi Valkeinen Message-ID: Date: Tue, 25 Aug 2020 16:16:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200823162625.GC4313@darkstar.musicnaut.iki.fi> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laurent, On 23/08/2020 19:26, Aaro Koskinen wrote: > Hi, > > On Tue, Aug 04, 2020 at 03:39:37PM +0300, Tomi Valkeinen wrote: >> On 04/08/2020 15:13, Tomi Valkeinen wrote: > >>> Can you try to pinpoint a bit where the hang happens? Maybe add >>> DRM/omapdrm debug prints, or perhaps sysrq works and it shows a lock >>> that's in deadlock. >> >> Also, one data point would be to disable venc, e.g. set venc status to >> "disabled" in dts. > > Disabling venc makes no difference. > > The hang happens in drm_fb_helper_initial_config(). I followed the > "HANG DEBUGGING" tips in the function comment text and enabled > fb.lockless_register_fb=1 to get more (serial) console output. > > Now I get this: > > [ 6.514739] omapdss_dss 48050000.dss: supply vdda_video not found, using dummy regulator > [ 6.566375] DSS: OMAP DSS rev 2.0 > [ 6.571807] omapdss_dss 48050000.dss: bound 48050400.dispc (ops dispc_component_ops) > [ 6.580749] omapdrm omapdrm.0: DMM not available, disable DMM support > [ 6.587982] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). > [ 6.626617] ------------[ cut here ]------------ > [ 6.631774] WARNING: CPU: 0 PID: 18 at drivers/gpu/drm/drm_bridge.c:708 drm_atomic_helper_commit_modeset_enables+0x134/0x268 > [ 6.643768] Modules linked in: > [ 6.647033] CPU: 0 PID: 18 Comm: kworker/0:1 Tainted: G U 5.8.0-omap3-los_16068+-00004-g2e7d4a7efefd-dirty #2 > [ 6.658966] Hardware name: Nokia RX-51 board > [ 6.663635] Workqueue: events deferred_probe_work_func > [ 6.669097] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [ 6.677429] [] (show_stack) from [] (__warn+0xbc/0xd4) > [ 6.684844] [] (__warn) from [] (warn_slowpath_fmt+0x60/0xb8) > [ 6.692901] [] (warn_slowpath_fmt) from [] (drm_atomic_helper_commit_modeset_enables+0x134/0x268) > [ 6.704254] [] (drm_atomic_helper_commit_modeset_enables) from [] (omap_atomic_commit_tail+0xb4/0xc0) > [ 6.715972] [] (omap_atomic_commit_tail) from [] (commit_tail+0x9c/0x1a8) > [ 6.725128] [] (commit_tail) from [] (drm_atomic_helper_commit+0x134/0x158) > [ 6.734466] [] (drm_atomic_helper_commit) from [] (drm_client_modeset_commit_atomic+0x16c/0x208) > [ 6.745727] [] (drm_client_modeset_commit_atomic) from [] (drm_client_modeset_commit_locked+0x58/0x184) > [ 6.757629] [] (drm_client_modeset_commit_locked) from [] (drm_client_modeset_commit+0x24/0x40) > [ 6.768798] [] (drm_client_modeset_commit) from [] (__drm_fb_helper_restore_fbdev_mode_unlocked+0xa0/0xc8) > [ 6.780975] [] (__drm_fb_helper_restore_fbdev_mode_unlocked) from [] (drm_fb_helper_set_par+0x38/0x64) > [ 6.792785] [] (drm_fb_helper_set_par) from [] (fbcon_init+0x3d4/0x568) > [ 6.801757] [] (fbcon_init) from [] (visual_init+0xb8/0xfc) > [ 6.809631] [] (visual_init) from [] (do_bind_con_driver+0x1e0/0x3bc) > [ 6.818267] [] (do_bind_con_driver) from [] (do_take_over_console+0x138/0x1d8) > [ 6.827880] [] (do_take_over_console) from [] (do_fbcon_takeover+0x74/0xd4) > [ 6.837219] [] (do_fbcon_takeover) from [] (register_framebuffer+0x204/0x2d8) > [ 6.846740] [] (register_framebuffer) from [] (__drm_fb_helper_initial_config_and_unlock+0x3a4/0x554) > [ 6.858459] [] (__drm_fb_helper_initial_config_and_unlock) from [] (omap_fbdev_init+0x84/0xbc) > [ 6.869537] [] (omap_fbdev_init) from [] (pdev_probe+0x580/0x7d8) > [ 6.877807] [] (pdev_probe) from [] (platform_drv_probe+0x48/0x98) Laurent, does this ring any bells? The WARN comes in drm_atomic_bridge_chain_enable() when drm_atomic_get_old_bridge_state() returns null for (presumably) sdi bridge. I'm not sure why the bridge state would not be there. Aaro, you can probably debug easier if you disable CONFIG_FRAMEBUFFER_CONSOLE, or even CONFIG_DRM_FBDEV_EMULATION. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki