From: Markus Elfring <Markus.Elfring@web.de>
To: Geetha sowjanya <gakula@marvell.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Hariprasad Kelam <hkelam@marvell.com>,
Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
Sunil Goutham <sgoutham@marvell.com>
Subject: Re: [net-next PATCH v5 02/10] octeontx2-pf: RVU representor driver
Date: Sat, 15 Jun 2024 17:11:53 +0200 [thread overview]
Message-ID: <ac47a370-99ca-4fb9-8fb0-800894d04c57@web.de> (raw)
In-Reply-To: <20240611162213.22213-3-gakula@marvell.com>
> This patch adds basic driver for the RVU representor.
…
Please improve such a change description with imperative wordings.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc3#n94
Can an adjusted summary phrase become also a bit more helpful?
https://elixir.bootlin.com/linux/v6.10-rc3/source/Documentation/process/maintainer-tip.rst#L124
…
> +static int rvu_get_rep_cnt(struct otx2_nic *priv)
> +{
…
> + mutex_lock(&priv->mbox.lock);
> + req = otx2_mbox_alloc_msg_get_rep_cnt(&priv->mbox);
…
> +exit:
> + mutex_unlock(&priv->mbox.lock);
> + return err;
> +}
…
Would you become interested to apply a statement like “guard(mutex)(&priv->mbox.lock);”?
https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/mutex.h#L196
…
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/rep.h
> @@ -0,0 +1,31 @@
…
> +#ifndef REP_H
> +#define REP_H
…
Can unique include guards be more desirable also for this software?
Regards,
Markus
next prev parent reply other threads:[~2024-06-15 15:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 16:22 [net-next PATCH v5 00/10] Introduce RVU representors Geetha sowjanya
2024-06-11 16:22 ` [net-next PATCH v5 01/10] octeontx2-pf: Refactoring RVU driver Geetha sowjanya
2024-06-15 11:15 ` Markus Elfring
2024-06-18 9:03 ` [EXTERNAL] " Geethasowjanya Akula
2024-06-18 7:40 ` Simon Horman
2024-06-24 9:56 ` Geethasowjanya Akula
2024-06-11 16:22 ` [net-next PATCH v5 02/10] octeontx2-pf: RVU representor driver Geetha sowjanya
2024-06-14 2:02 ` Jakub Kicinski
2024-06-18 9:08 ` [EXTERNAL] " Geethasowjanya Akula
2024-06-15 15:11 ` Markus Elfring [this message]
2024-06-17 19:49 ` Simon Horman
2024-06-25 11:58 ` [EXTERNAL] " Geethasowjanya Akula
2024-06-11 16:22 ` [net-next PATCH v5 03/10] octeontx2-pf: Create representor netdev Geetha sowjanya
2024-06-18 8:25 ` Simon Horman
2024-06-24 8:49 ` Geethasowjanya Akula
2024-06-11 16:22 ` [net-next PATCH v5 04/10] octeontx2-pf: Add basic net_device_ops Geetha sowjanya
2024-06-11 16:22 ` [net-next PATCH v5 05/10] octeontx2-af: Add packet path between representor and VF Geetha sowjanya
2024-06-17 20:19 ` Simon Horman
2024-06-18 8:38 ` Simon Horman
2024-06-19 12:16 ` [EXTERNAL] " Geethasowjanya Akula
2024-06-11 16:22 ` [net-next PATCH v5 06/10] octeontx2-pf: Get VF stats via representor Geetha sowjanya
2024-06-20 12:54 ` Simon Horman
2024-06-20 12:56 ` Simon Horman
2024-06-11 16:22 ` [net-next PATCH v5 07/10] octeontx2-pf: Add support to sync link state between representor and VFs Geetha sowjanya
2024-06-20 12:56 ` Simon Horman
2024-06-11 16:22 ` [net-next PATCH v4 08/10] octeontx2-pf: Configure VF mtu via representor Geetha sowjanya
2024-06-20 12:56 ` Simon Horman
2024-06-11 16:22 ` [net-next PATCH v5 09/10] octeontx2-pf: Add representors for sdp MAC Geetha sowjanya
2024-06-18 8:55 ` Simon Horman
2024-06-11 16:22 ` [net-next PATCH v5 10/10] octeontx2-pf: Add devlink port support Geetha sowjanya
2024-06-20 12:57 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac47a370-99ca-4fb9-8fb0-800894d04c57@web.de \
--to=markus.elfring@web.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®