mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Shenghao Ding <shenghao-ding@ti.com>,
	broonie@kernel.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, robh+dt@kernel.org,
	andriy.shevchenko@linux.intel.com, linux-sound@vger.kernel.org,
	liam.r.girdwood@intel.com, lgirdwood@gmail.com,
	linux-kernel@vger.kernel.org
Cc: kevin-lu@ti.com, baojun.xu@ti.com, v-po@ti.com, navada@ti.com,
	perex@perex.cz, j-mcpherson@ti.com,
	pierre-louis.bossart@linux.intel.com, 13916275206@139.com,
	mohit.chawla@ti.com, soyer@irl.hu, jkhuang3@ti.com,
	tiwai@suse.de, pdjuandi@ti.com, manisha.agrawal@ti.com,
	s-hari@ti.com, aviel@ti.com, hnagalla@ti.com, praneeth@ti.com
Subject: Re: [PATCH v3 4/4] ASoc: dt-bindings: PCM6240: Add initial DT binding
Date: Tue, 6 Feb 2024 14:52:41 +0100	[thread overview]
Message-ID: <ac4b73f6-0c2c-4586-98d6-e97c575b3df7@linaro.org> (raw)
In-Reply-To: <20240203030504.1724-4-shenghao-ding@ti.com>

On 03/02/2024 04:05, Shenghao Ding wrote:
> +
> +      ti,tad5212: Low-power stereo audio DAC with 120-dB dynamic range.
> +    oneOf:
> +      - items:
> +          - enum:
> +              - ti,adc3120
> +              - ti,adc5120
> +              - ti,pcm3120
> +              - ti,pcm5120
> +              - ti,pcm6120
> +          - const: ti,adc6120
> +      - items:
> +          - enum:
> +              - ti,pcm6260
> +              - ti,pcm6140
> +              - ti,pcm3140
> +              - ti,pcm5140
> +          - const: ti,pcm6240
> +      - items:
> +          - const: ti,dix4192
> +          - const: ti,pcm6240

Why dix4192 is not part of previous enum?

> +      - items:
> +          - const: ti,adc6120
> +          - const: ti,pcmd512x
> +      - items:
> +          - const: ti,pcm1690
> +          - const: ti,pcm9211
> +      - items:
> +          - enum:
> +              - ti,pcmd3180
> +          - const: ti,pcmd3140
> +      - items:
> +          - enum:
> +              - ti,taa5412
> +          - const: ti,taa5212
> +      - items:
> +          - enum:
> +              - ti,tad5412
> +          - const: ti,tad5212
> +      - enum:
> +          - ti,pcm6240
> +          - ti,pcmd3140
> +          - ti,taa5212
> +          - ti,tad5212
> +          - ti,pcmd3180

This one is duplicated.

> +


Best regards,
Krzysztof


  reply	other threads:[~2024-02-06 13:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-03  3:04 [PATCH v3 1/4] ASoc: PCM6240: Create PCM6240 Family driver code Shenghao Ding
2024-02-03  3:05 ` [PATCH v3 2/4] ASoc: PCM6240: Create header file for " Shenghao Ding
2024-02-03  3:05 ` [PATCH v3 3/4] ASoc: PCM6240: Add compile item for PCM6240 Family driver Shenghao Ding
2024-02-03  3:05 ` [PATCH v3 4/4] ASoc: dt-bindings: PCM6240: Add initial DT binding Shenghao Ding
2024-02-06 13:52   ` Krzysztof Kozlowski [this message]
2024-02-07  9:47     ` [EXTERNAL] " Ding, Shenghao
2024-02-07  9:50       ` Ding, Shenghao
2024-02-07  9:53       ` Krzysztof Kozlowski
2024-02-07  9:57         ` Ding, Shenghao
2024-02-07 10:28         ` Mark Brown
2024-02-05 15:05 ` [PATCH v3 1/4] ASoc: PCM6240: Create PCM6240 Family driver code Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac4b73f6-0c2c-4586-98d6-e97c575b3df7@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=13916275206@139.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=aviel@ti.com \
    --cc=baojun.xu@ti.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hnagalla@ti.com \
    --cc=j-mcpherson@ti.com \
    --cc=jkhuang3@ti.com \
    --cc=kevin-lu@ti.com \
    --cc=lgirdwood@gmail.com \
    --cc=liam.r.girdwood@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=manisha.agrawal@ti.com \
    --cc=mohit.chawla@ti.com \
    --cc=navada@ti.com \
    --cc=pdjuandi@ti.com \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=praneeth@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=s-hari@ti.com \
    --cc=shenghao-ding@ti.com \
    --cc=soyer@irl.hu \
    --cc=tiwai@suse.de \
    --cc=v-po@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®