mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adam Jackson <ajax@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, dri-devel@lists.freedesktop.org
Cc: David Airlie <airlied@linux.ie>, Dave Airlie <airlied@redhat.com>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" 
	<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v3] drm/cirrus: flip default from 24bpp to 16bpp
Date: Wed, 08 Aug 2018 09:57:50 -0400	[thread overview]
Message-ID: <ac4f27f33cbe87bea059145ec669b3c00961d61f.camel@redhat.com> (raw)
In-Reply-To: <20180808111311.30311-1-kraxel@redhat.com>

On Wed, 2018-08-08 at 13:13 +0200, Gerd Hoffmann wrote:
> The problem with 24bpp is that it is a rather unusual depth these days,

Nit: s/depth/bpp/ here. Depth 24 is very common, it's packing that into
three bytes per pixel that's unusual.

> cirrus is pretty much the only relevant device still using that, and it
> is a endless source of issues.  Wayland doesn't support it at all.  Bugs
> in Xorg keep showing up.
> 
> Typically either 32bpp or 16bpp are used.  Using 32bpp would limit the
> resolution to 800x600 due to hardware constrains.  So lets go with 16bpp.
> 
> Also use the default depth for the framebuffer console and
> mode_info->preferred_depth.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Reviewed-by: Adam Jackson <ajax@redhat.com>

- ajax

      reply	other threads:[~2018-08-08 13:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-08 11:13 Gerd Hoffmann
2018-08-08 13:57 ` Adam Jackson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac4f27f33cbe87bea059145ec669b3c00961d61f.camel@redhat.com \
    --to=ajax@redhat.com \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kraxel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®