From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Erikas Bitovtas <xerikasxx@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] iio: light: vcnl4000: register an IIO device with a device-managed function
Date: Thu, 2 Apr 2026 11:20:04 +0300 [thread overview]
Message-ID: <ac4mtHHvS_k9xCAI@ashevche-desk.local> (raw)
In-Reply-To: <20260401-vcnl4000-drop-enum-v1-3-ffd201f0c848@gmail.com>
On Wed, Apr 01, 2026 at 02:22:38PM +0300, Erikas Bitovtas wrote:
> Use a device-managed counterpart of iio_device_register() and remove the
> redundant iio_device_unregister() call in driver remove function.
...
> - ret = iio_device_register(indio_dev);
> + ret = devm_iio_device_register(dev, indio_dev);
> if (ret < 0)
> goto fail_poweroff;
^^^^ This goto is sign of a still existing ordering issue. so this patch is half-baked.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-04-02 8:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 11:22 [PATCH 0/3] iio: light: vcnl4000: drop enum ID table and use device-managed register Erikas Bitovtas
2026-04-01 11:22 ` [PATCH 1/3] iio: light: vcnl4000: validate device by prod ID instead of table ID Erikas Bitovtas
2026-04-01 11:22 ` [PATCH 2/3] iio: light: vcnl4000: drop enum id table in favor of chip structs Erikas Bitovtas
2026-04-02 8:21 ` Andy Shevchenko
2026-04-01 11:22 ` [PATCH 3/3] iio: light: vcnl4000: register an IIO device with a device-managed function Erikas Bitovtas
2026-04-02 8:20 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac4mtHHvS_k9xCAI@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=xerikasxx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®