From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751534AbdFHHtm (ORCPT ); Thu, 8 Jun 2017 03:49:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:33706 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750752AbdFHHtl (ORCPT ); Thu, 8 Jun 2017 03:49:41 -0400 Subject: Re: [PATCH v6 05/10] nvmet: implement namespace identify descriptor list To: Christoph Hellwig Cc: Sagi Grimberg , Keith Busch , Hannes Reinecke , Max Gurtovoy , Linux NVMe Mailinglist , Linux Kernel Mailinglist References: <20170607094536.32419-1-jthumshirn@suse.de> <20170607094536.32419-6-jthumshirn@suse.de> <20170608074414.GD13953@lst.de> From: Johannes Thumshirn Message-ID: Date: Thu, 8 Jun 2017 09:49:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170608074414.GD13953@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/08/2017 09:44 AM, Christoph Hellwig wrote: >> + if (sg_zeroout_area(req->sg, req->sg_cnt, NVME_IDENTIFY_DATA_SIZE, off) > > Shouldn;t the third argument be NVME_IDENTIFY_DATA_SIZE - off in theory? > It's probably fine as is as the S/G helpers deal with overflows > gracefully, but still.. Ahm yes. *doh* Can you fix it up when applying? -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850