From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F7642D9796 for ; Wed, 18 Feb 2026 13:32:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771421567; cv=none; b=h0idRATJFYk8rFxhbSm2mx8NKAfMm4nW0xeQePkSaILAmVmVkmhlgWsNBujqEySoEdpYfnhaCnmEWhSyKXwtoSJ4X7KLD4i8O8Z5sz7oAGGaH9i9eCG3uJhjEexGyAd6LS1SbEMzQ6YRgnkmw5O/AmED4ARdE8QC/sljlf3e2Cc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771421567; c=relaxed/simple; bh=QedJur50/g6zcxoZnzhwRn25RyISmPBtgycbNB4XN0s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mAZ2PBOBrTcTrhNMyzTOfQLK/Rct4LYm3V5J/PbxaJgSbRtd6ulTO2jXofQWXtnWZhDhYNoe4RikBdS6gsJfkzBtRBEI4VmlGtmJqiAzyaVxIbLoe5m8hNJ5Gu+XgcBTEv6otZtKYQu2O3nlnOBxU7R5574AyBW/b02eMDh4rJ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=K9RUELf5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Mlam3o4k; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="K9RUELf5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Mlam3o4k" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61I5K1fi421978 for ; Wed, 18 Feb 2026 13:32:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BiLp20Q3kkEwTZ8fNKmZyNSU4zyYxn1pttaJh2zFj0w=; b=K9RUELf5+j59icvH CCmI2iU1nfwDZIJnFK+IzPEpzotxDD4PbnH0kq0lfD4TY8Fol6HhHO2aTuKfWbIV vHK6Hg6JoX5mNqsv2D5BZQ5DzvtJ6w7mESqceeSo6gCBIuFUr7iiJNMl5rZ+jKN5 /3uy05nIcvaqANZD+A0BUz67ZACdiv/+ormMmT/fgKtmW33Q6imRkUcF7dPsBFaZ uN+81kWFLkYs6jFyI6uWXylInqSaQIcLa1lOBRP692NX9PlHHE6MgtWfj6VvFonm YyCnX/YzjtS5ZSGNsgRMMc5ozbF7gRmsNkoFBPSafF0r854ypGER4Fra12vs2x2j 1PZOZQ== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cd76e155n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Feb 2026 13:32:45 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8954937be97so45648836d6.1 for ; Wed, 18 Feb 2026 05:32:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771421564; x=1772026364; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BiLp20Q3kkEwTZ8fNKmZyNSU4zyYxn1pttaJh2zFj0w=; b=Mlam3o4kozt8aCKuNjGR4GXAYZlhX3UWRxgAcEKhFQJ9nH6VVLrkLKoD/nw4Gh1+L2 ESYy1xer4ng7RrlsR43bkvLBR/O+XvEH4IW7W2tv0HO2duLz377VCiTpIs4TUE0MPWEg hyNgZ3zrffjJ75L4KLsYrtK6LlpVARf3Qiu72TI5P6maivc25YmPmXkKJofkOY1vrN3Q cF+9qoT0dwDH19PLO8C7P3XCOwI45aquI2z1Njitf86E6fHIy+tlz9vKZYE1Fxt8pmSI R+QCKfvqi3uL97/+IOv+Ua8jlTjJkWETHu18gwyn0+rLFsJALNZc2XV6FH5tdFKj+Lgq uvRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771421564; x=1772026364; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BiLp20Q3kkEwTZ8fNKmZyNSU4zyYxn1pttaJh2zFj0w=; b=VerXaOEIOYt2wjBs3AhAW29rlWpj5MgPcnIGc3fojr5/G2sAmJwOE9UvKbZupw5xhW AydFnd26qTE0V7GADJU9kIDBgGF+A7jRwiMluhfLGPp9qqqfJlQs1yfdn8iwaT0fJwWq ARtSffCKBv5io/hiC8LxbSXIjzzkT3J+/eJg/vG5/YPMPzH9BHDwr31xVnfmjWHdzQts WueSq8zloByfZDrM5mm9IBPk6vAqMqVHcOL7zmjIec6FfXicF0ihZ0P2n2m0bRBhnh/5 lxnS04v11x6XN93UlIXK2MSi4K/jwgm8TS8RxqmJOIX94dFeETTX38PvuiGUKxwAdZ8L D4Xw== X-Forwarded-Encrypted: i=1; AJvYcCUFxFgHEVAgmKqeP2wP+Vf3SAWFVfHNX/afmoZuo8CldkBR+XpJEfTcjY5grLqANUmzi81cBIAADZTWWhA=@vger.kernel.org X-Gm-Message-State: AOJu0YzQmzUen24OkSlX4pHrSZbQR4jUN+kIX2VC1ypiaiAOm2200GK4 gwdVZqW8yErJukdhvgbfKzx6CrNMlpBCkFKKdzJRJxrRN96WQQMuYPSA8U86awXIphsMkswKzLe GcOxzlQHl3YqoLrjT5WXCbelXxzLpa8+/RUl7iF4OuMNUbuEojRX+L+zKiXhyfbUHydI= X-Gm-Gg: AZuq6aLgXZygQ3VW3KhGA8SvrPA10YHxENa17vrQv/ufuds9YyEjx39fhAasccXjgRz Knf8yHXoqgeF6dkTh53tlMAVSFv70b+J3waRzvijAfaePymDbq7RqEAEkI8H5Kt4wTOxBDLumPt 98+gQPbkpsQTRVEhLmA41k8KVrpHqDiYEpYqt+jNyWBjaZZey+iPc440BEeV3GCwSgMAGfGQN3V tubPOwZpVcM09iSgvYl38MgAf17KTcUXFxWPLmNNzWDL7VKJTyTgPg6LHmhUrjYj+dBDpRlhBIF 82jy5xEZR89lS2A6wHLooMdxGa+Lphj1zrdgNS1ApvKs9+lVZ0WYGuTOml/Fx+k2wDejTyYAyXF zAdIuCf+cp6Jjx7/OipRDbWfm4C4P9Kd0eYJK3Foaad+0t+7BcIOGLSbghMKeqA4Vv+7hkedu9N tZ4BfgVqTvY59lBw== X-Received: by 2002:a05:6214:4f05:b0:897:1d50:2336 with SMTP id 6a1803df08f44-897347ccd64mr191548926d6.6.1771421564483; Wed, 18 Feb 2026 05:32:44 -0800 (PST) X-Received: by 2002:a05:6214:4f05:b0:897:1d50:2336 with SMTP id 6a1803df08f44-897347ccd64mr191548556d6.6.1771421564012; Wed, 18 Feb 2026 05:32:44 -0800 (PST) Received: from [192.168.0.242] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8fc73f102dsm446535266b.26.2026.02.18.05.32.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Feb 2026 05:32:43 -0800 (PST) Message-ID: Date: Wed, 18 Feb 2026 14:32:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 1/3] dt-bindings: sram: qcom,imem: Allow modem-tables subnode To: Krzysztof Kozlowski , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alex Elder , Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20260217-topic-ipa_imem-v3-0-d6d8ed1dfb67@oss.qualcomm.com> <20260217-topic-ipa_imem-v3-1-d6d8ed1dfb67@oss.qualcomm.com> <20260217-godlike-silent-owl-0a8487@quoll> <36f0a71c-a8b7-4aaa-81c3-1945b268c57f@oss.qualcomm.com> <0bfcb292-4e49-4047-b631-dd3029b43f1c@kernel.org> <193d236b-864b-45bd-b0a9-6efbdccf6db9@oss.qualcomm.com> <9bfb4ef0-49a1-4127-aad4-2ba1b9dd8e95@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <9bfb4ef0-49a1-4127-aad4-2ba1b9dd8e95@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=OKsqHCaB c=1 sm=1 tr=0 ts=6995bf7d cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=ZflIhQ0aK2eKklpQHNMA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE4MDExNSBTYWx0ZWRfX4Y8RV9hJJxpg reYeu00s2o4+QsZXwEf/0qXz3+tNRpc/GWmAt0fVIwuAPekvLcM8+uv/zEUUTMJ/0OOLOVRK1+C zXj3V6yopA8VPzZTarvx2uFxwpTj9cxMSYFVACzxdJUXWiRtaxn4+QHp7WqzwruI8kgmnypq8YT er0Gwj9TFWPnjS3rccDVMxF/dbjknn0bpvlwF6pPdoNM/XJFjvh6R2xuzQPA+g3kvDXiqNj8ixK XYWHKG7H19R8IpUVU5h5EqkUXlOhCob/+4wm3xlME5LhLGFF34Ehpu3EdgY5Rwyku1sWmR2ZeHR vYupBvH9ZTEgfG/gKgh3qFK/ZYtZkIlq/Wtvb4TMzJ7d66GffUZIA42ze8EA7vjjAzg7vvJ02Rr aNQrBKaYlIhiIuljPfn68571Zklthq87Fdvip/vM9tQm7NcujsPvtCOhNRqiJiUm49PmaynVJfi 5N04ceH3T2jDiUGrBZQ== X-Proofpoint-GUID: KpA-UV3BvL0g8cSiMR5EfS8tei7v2RxB X-Proofpoint-ORIG-GUID: KpA-UV3BvL0g8cSiMR5EfS8tei7v2RxB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-18_02,2026-02-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 impostorscore=0 adultscore=0 suspectscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602180115 On 18-Feb-26 14:21, Krzysztof Kozlowski wrote: > On 18/02/2026 13:26, Konrad Dybcio wrote: >> >> >> On 18-Feb-26 12:56, Krzysztof Kozlowski wrote: >>> On 18/02/2026 12:05, Konrad Dybcio wrote: >>>> On 2/17/26 9:25 PM, Krzysztof Kozlowski wrote: >>>>> On Tue, Feb 17, 2026 at 02:30:31PM +0100, Konrad Dybcio wrote: >>>>>> From: Konrad Dybcio >>>>>> >>>>>> The IP Accelerator hardware/firmware owns a sizeable region within the >>>>>> IMEM, named 'modem-tables', containing various packet processing >>>>>> configuration data. >>>>>> >>>>>> It's not actually accessed by the OS, although we have to IOMMU-map it >>>>>> with the IPA device, so that presumably the firmware can act upon it. >>>>>> >>>>>> Allow it as a subnode of IMEM. >>>>> >>>>> You do not have compatible, so rely on the node name as ABI, which is >>>>> fine in general but... I do not see usage of it in the driver. Why do >>>>> you need to define modem-tables child then? >>>> >>>> I don't really *need* the node name to be an ABI. However, the current >>>> binding for IMEM only allows a named "pil-reloc@.." subnode (which is >>>> consumed via of_find_compatible_node() in the remoteproc subsystem) so I >>>> figured the intention was to keep the list of allowed subnodes strictly >>>> moderated >>>> >>>> If you'd prefer a blanket pattern declaration with say '^[a-z]@[0-9a-z]+$' >>>> with just a reg requirement inside, I'm fine with that too >>> >>> No, the problem is that you do not use the ABI here at all. Neither >>> would you use the blanket pattern, so my question stays: why adding ABI >>> which is not used? >> >> The subnode I'm trying to introduce is going to be consumed (via a >> phandle reference) from the IPA node, as done by the remaining 2 >> patches in this series. > > And that's the problem - I do not see consuming child. I see > of_parse_phandle to sram node, not the child. Ah, I just realized this series has no DT examples.. The property I proposed to add into the IPA node&code is indeed named 'sram', but my intention is to pass a phandle to the *child* (similarly like we pass a phandle to the child of a nvmem provider rather than to the provider device itself) i.e. the design I envisioned is: imem@foo { ... ipa_modem_tables: modem-tables@1234 { reg = <0x1234 0x1234>; }; }; ... ipa@foobar { ... sram = <&ipa_modem_tables>; } Konrad