From: Fenghua Yu <fenghuay@nvidia.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, james.morse@arm.com
Cc: ben.horgan@arm.com, reinette.chatre@intel.com,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] arm_mpam: Remove duplicate linux/srcu.h header
Date: Fri, 21 Nov 2025 15:15:22 -0800 [thread overview]
Message-ID: <ac5715f0-6efb-4e58-be6c-e8b3a15b4e1e@nvidia.com> (raw)
In-Reply-To: <20251121033912.3787219-1-jiapeng.chong@linux.alibaba.com>
Hi, Jiapeng,
On 11/20/25 19:39, Jiapeng Chong wrote:
> ./drivers/resctrl/mpam_internal.h: linux/srcu.h is included more than once.
>
Do you need to add "Fixes:" here?
Fixes: 8c90dc68a5de ("arm_mpam: Probe the hardware features resctrl
supports")
Not sure it's necessary for this minor fix but
Documentations/process/submitting-patches.rst says "If your patch fixes
a bug in a specific commit, e.g. you found an issue using
``git bisect``, please use the 'Fixes:' tag with at least the first 12
characters of the SHA-1 ID, and the one line summary. Do not split the tag
across multiple lines, tags are exempt from the "wrap at 75 columns" rule in
order to simplify parsing scripts."
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=27328
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/resctrl/mpam_internal.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/resctrl/mpam_internal.h b/drivers/resctrl/mpam_internal.h
> index e79c3c47259c..f733bed011bd 100644
> --- a/drivers/resctrl/mpam_internal.h
> +++ b/drivers/resctrl/mpam_internal.h
> @@ -14,7 +14,6 @@
> #include <linux/mutex.h>
> #include <linux/srcu.h>
> #include <linux/spinlock.h>
> -#include <linux/srcu.h>
> #include <linux/types.h>
>
> #define MPAM_MSC_MAX_NUM_RIS 16
Thanks.
-Fenghua
next prev parent reply other threads:[~2025-11-21 23:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 3:39 Jiapeng Chong
2025-11-21 23:15 ` Fenghua Yu [this message]
2025-11-25 11:33 ` James Morse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac5715f0-6efb-4e58-be6c-e8b3a15b4e1e@nvidia.com \
--to=fenghuay@nvidia.com \
--cc=abaci@linux.alibaba.com \
--cc=ben.horgan@arm.com \
--cc=james.morse@arm.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®