From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EA56278E7B for ; Thu, 5 Jun 2025 19:10:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749150629; cv=none; b=BbONU9R9vkrzZGldyRA/Pzq5DInKfXa2Vn05kiemSKQbM68CcZjl4IkwfMsUywBqAAgFTQstytsBzo/ecf5VbDMeK4FY9MwmoY0Yf2mgoDiL1p44u1NxlWmhu8DzFw722X+UVXZOZORSh/3vh3y+z9tXGH5Jw2tPGBgaRhT8/f4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749150629; c=relaxed/simple; bh=BzhDXvO+fo6vdDlGvPLhFLjNB66knyQPyVH22yq04h4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cMs7H3sQdidK8lt/nKv8+FE2IZnBDrLKsM4svxI+YWzrOdQflfVTP5ObtrBSMumRwVZjNgEFFoSiiOFtqavLvACk66OQXcosJl/PSe3Qp+1N14EwV2LUGu/qy2TLghWrG51nD4EXEfid3TXYbPhVZ1fhMnaCGZbh8kCgy11TAlQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=CvjQVrj0; arc=none smtp.client-ip=209.85.214.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="CvjQVrj0" Received: by mail-pl1-f195.google.com with SMTP id d9443c01a7336-22d95f0dda4so18304755ad.2 for ; Thu, 05 Jun 2025 12:10:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1749150626; x=1749755426; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=S8Q01zwWnDH2jcws9vUi105eGLMi3lYwKgILJyKyZOU=; b=CvjQVrj0GQ+7D+6il8tY5VFKMtQd35LjQywutk4BFTQY91swbXtxl+EEPcLxSFmR05 CRZJGv2XwcuNcpHiaAKzEJ67Sy3WvN02DCNhw8KPF1OKvhAWIOpOP36vDwoMSh+0jw// OFAvyodqdKGkkYheOYgGMFAN9RY1urgMB+NdI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749150626; x=1749755426; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=S8Q01zwWnDH2jcws9vUi105eGLMi3lYwKgILJyKyZOU=; b=g89bXIQSsgOKO33HV4JAcWJQtX6D/mgHx7EW1zYiP/4RCKonEQVXHm+hTP+udGrhIT E07sKiPTbfa127NhsE4SDok4D3zrCsqw9S3MAou+9Yg2X+HG27jrc3ro8kXJuGMIeYsg HHAx0Fwo+SyvgDPp1sgPvMn40lKc1BvwkOJ3eTvKREBWxrWK5ZMLZf4B9QHSgThLhYkK 0UoAuheGHDTNSoLr9GAOJkF3N/NDTESIPvVmVvtJRNOzC+Uok8UB7Le15jmkJcd40+R1 ZlNocef+P1PgbI0msmpLjKBh0g9BLNO6OqKprKP/c/C0gBPwuio7fkk/xc8XlM6vdX/F mFZA== X-Gm-Message-State: AOJu0Yx/wxpQrPi7H227UqSoWjl78V+GE7Qan5kxku4LNgC8HLhP8oaD hkMKfrNKLBXlYbQx0aqH8Hlm+F9ppCvvVIHoXpNTvUTObceof1wHsIstUk1FJGPj8w== X-Gm-Gg: ASbGnctHNlg9Gc4rJn5gl7fAES5g9vuu5ODLINwMgvdfqy/xRR258xTGVEgHK+wpHPV pYVbwpYUNYydcJc/s2Cq5SQpTjiQsDntW1T05/DC3FR+IBd53oW4MEenZZ4hpm7yExpHG6JeBvr XQYIR0gVcxYt0gNPw7Pl7O9pQfcwwUdT3AsbDoeSD8SU1U21yW3TAqqRgiupRh31vG7V7gtthED Zafx/T4z2KVlnIxioLZ9TkeLLXrePOfigBlPjU9FRq9tkQDU6quE9H4UP+Ujb00gJmTY+qSaQ4+ webkksH1yEewVk9qOjCA4TVCtuSz2Rag3nZZ4NIBw8G5ud5Rtz28y78sKAuqn9caXGI7O9JCXN0 W7iQStZAUGjtAp+c= X-Google-Smtp-Source: AGHT+IH8uMPfDU2hWPBfSee1riTDDvC6J/TIxbPRoKG9On+pgfWIdYZeF7y84NvovZbhYEH2dSNdRA== X-Received: by 2002:a17:902:b205:b0:234:cb4a:bc48 with SMTP id d9443c01a7336-23601d1993cmr5856905ad.31.1749150626567; Thu, 05 Jun 2025 12:10:26 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b2f5f66a87fsm37744a12.39.2025.06.05.12.10.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jun 2025 12:10:25 -0700 (PDT) Message-ID: Date: Thu, 5 Jun 2025 12:10:24 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] memory: brcmstb_memc: Simplify compatible matching To: Rob Herring Cc: linux-kernel@vger.kernel.org, justin.chen@broadcom.com, Krzysztof Kozlowski , Conor Dooley , Broadcom internal kernel review list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" References: <20250523184354.1249577-1-florian.fainelli@broadcom.com> <20250523184354.1249577-3-florian.fainelli@broadcom.com> <20250605185557.GA3023589-robh@kernel.org> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20250605185557.GA3023589-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/5/25 11:55, Rob Herring wrote: > On Fri, May 23, 2025 at 11:43:54AM -0700, Florian Fainelli wrote: >> Now that a "brcm,brcmstb-memc-ddr-rev-b.2.x" fallback compatible string >> has been defined, we can greatly simplify the matching within the driver >> to only look for that compatible string and nothing else. >> >> The fallback "brcm,brcmstb-memc-ddr" is also updated to assume the V21 >> register layout since that is the most common nowadays. >> >> Signed-off-by: Florian Fainelli >> --- >> drivers/memory/brcmstb_memc.c | 58 ++--------------------------------- >> 1 file changed, 3 insertions(+), 55 deletions(-) >> >> diff --git a/drivers/memory/brcmstb_memc.c b/drivers/memory/brcmstb_memc.c >> index c87b37e2c1f0..ec4c198ddc49 100644 >> --- a/drivers/memory/brcmstb_memc.c >> +++ b/drivers/memory/brcmstb_memc.c >> @@ -181,65 +181,13 @@ static const struct of_device_id brcmstb_memc_of_match[] = { >> .data = &brcmstb_memc_versions[BRCMSTB_MEMC_V20] >> }, >> { >> - .compatible = "brcm,brcmstb-memc-ddr-rev-b.2.1", >> + .compatible = "brcm,brcmstb-memc-ddr-rev-b.2.x", >> .data = &brcmstb_memc_versions[BRCMSTB_MEMC_V21] > > This entry is pointless because the default will get V21. > > In fact, I don't think you need the new compatible string at all. It > doesn't work to add fallbacks after the fact. I agree and would prefer to keep adding new compatible strings which is what I initially did here: https://lore.kernel.org/all/20241217194439.929040-2-florian.fainelli@broadcom.com/ but the feedback was that this should not be done, and hence this attempt at defining a compatible string that would avoid needless churn. So which way should I go now? -- Florian