From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B55C31E0DD7 for ; Mon, 21 Oct 2024 07:49:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729496947; cv=none; b=KjkkmpCzwH79G8uYJDy4aB/tCA6EUbbl2OhvKukfS0oSAqAZH9bc9UKPYQ981png6gHyuJpT9nMm9e81OXF8bFnJDBpgGTB6l0sRnPa6ITq/Po218dDir/VXuOlYhLtQ2ZsZGyOe3TCA/p+cSVBBMKWQsvnd8Ys/73kDEljC8hM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729496947; c=relaxed/simple; bh=rffjgAP5ZW88uPUrtaJRFYw7UB1XrEHtwZdvD7+yIv8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eWOokqX5idmZLNkzxFzkd02MJCKgiVswqfAEdCws2XcDdgPFuaLZszK0+P4g6hMVBK1zok84R5aSNqWUz9Ac/FOkmTZik99SloXerCR5ZjPYY7Glpel35rt9fCjtpFRm1EHdgysYNTFfVzmnK+VLo1cilOUbGNdZDJkl3qiQAs4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=rMZ/x6z0; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="rMZ/x6z0" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43161c0068bso27366935e9.1 for ; Mon, 21 Oct 2024 00:49:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1729496944; x=1730101744; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=58kG6E9taHK6TTsZfdidB/P2/Hcxp/vWM653t/Aj+tg=; b=rMZ/x6z0IHP1GC/SL4MpNjxOJUV4hJ9+9U1c6iA8pmJFsTVjhsxiM5DBzWJwvykaU0 05GABRaIudHCFZ81wDK4zInJ7hGJ8l8DXmlrPyD/za6YLufEYtTypMS39M09KfE9/9ch u65GYXAPs58zK3RmT9TT7Jblbz921ViSyh7BuqtylYHtPUeFneJwq1OYUU2EDi/41rX2 dC5Uu//X0b7EyX8YjfVvn/fJLVcM5nOg03D5vmmhNe1OksDouIsEitzrZuEGxS0cxsNJ SBB5BTU+Fso0ZdUppH4RNDc0yi87J5w2LLbXH/vUhEE6xRJwkV0wUU/zF503I3hxT80p 8dkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729496944; x=1730101744; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=58kG6E9taHK6TTsZfdidB/P2/Hcxp/vWM653t/Aj+tg=; b=XHKv1ZmLY5tvhMcUHxD3EWM2FqFjKr3NvK3zZTvXYwbBOnZIVOaSkfnyHgC8RmV1XU z2qHAsOOe8QOWp7S2dOwVANq5wJDjgvyofr1U1qeIPC32lWwbYi1xmpec8Npx3yP8mU+ YqTlHsrC298/DyexxqOr5shN6uCYBkS5N+qSal4+b09ITlC+FcRmFf7iBT/eraJk8LIG MTZ0HPjjKjYt2oHJQSVXsAMFipLSN7U93oPu7nx1O+fqVZ80eD5b8xYGJlj6aEy+PKil Nh0Hd+QFJ9iDXTMd0oPJ1DQsYw2NQkpUv85OF4KhCeajcsm8wo4GNfyzQvzVV4z89Mlc xSNA== X-Forwarded-Encrypted: i=1; AJvYcCU2XoA5H24/XXZiWy0y1JMEJmYyv0bs3DdnzODupfdIuEbGWXE9v/sxCjbpzqHvrttccnNXNTEJeKVZQxY=@vger.kernel.org X-Gm-Message-State: AOJu0YwQ2zZn7rl5yPe/JavWIRXMfVGQLO+I/r8iTAy8D8bbR7/TezJ9 abSsLLFehWxqzpdr5uev96gXcNIIIBKhkeiPCVxQ+I2kICYc9H03cT/Fuk6HEfw= X-Google-Smtp-Source: AGHT+IFvgo6qt2vB4D+5CxWmwBneFTMm7VvkmB3DADmGjcvJnOJUVQG58Cd4uUg0J+6QI23+xFjXxA== X-Received: by 2002:a05:600c:4595:b0:431:3b53:105e with SMTP id 5b1f17b1804b1-4316163bccfmr91296875e9.9.1729496943898; Mon, 21 Oct 2024 00:49:03 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.23]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4316f5cc921sm47137075e9.46.2024.10.21.00.49.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Oct 2024 00:49:02 -0700 (PDT) Message-ID: Date: Mon, 21 Oct 2024 10:49:01 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 03/12] dt-bindings: clock: renesas,r9a08g045-vbattb: Document VBATTB Content-Language: en-US To: Krzysztof Kozlowski Cc: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, alexandre.belloni@bootlin.com, magnus.damm@gmail.com, p.zabel@pengutronix.de, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Claudiu Beznea References: <20241019084738.3370489-1-claudiu.beznea.uj@bp.renesas.com> <20241019084738.3370489-4-claudiu.beznea.uj@bp.renesas.com> <5fddjnvzu2e74rtmqw6o2w5upxn6dpih3hmdbgiky75qyuvyum@ilch2rahnmih> From: Claudiu Beznea In-Reply-To: <5fddjnvzu2e74rtmqw6o2w5upxn6dpih3hmdbgiky75qyuvyum@ilch2rahnmih> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 21.10.2024 10:34, Krzysztof Kozlowski wrote: > On Mon, Oct 21, 2024 at 09:32:37AM +0200, Krzysztof Kozlowski wrote: >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + #include >>> + #include >>> + #include >>> + #include >>> + >>> + clock-controller@1005c000 { >>> + compatible = "renesas,r9a08g045-vbattb"; >>> + reg = <0x1005c000 0x1000>; >>> + interrupts = ; >>> + clocks = <&cpg CPG_MOD R9A08G045_VBAT_BCLK>, <&vbattb_xtal>; >>> + clock-names = "bclk", "rtx"; >>> + assigned-clocks = <&vbattb VBATTB_MUX>; >>> + assigned-clock-parents = <&vbattb VBATTB_XC>; >> >> Why are you configuring internal clocks to internal parents? That's part >> internal to this device, not DTS... or at least some explanation would >> be useful. > > From DTS I see this belongs to the board, not SoC, so makes sense. That's true. This configuration depends on the type of the input clock connected to the RTXIN, RTXOUT pins which is board specific (see below diagram): +----------+ XC `\ RTXIN --->| |----->| \ +----+ VBATTCLK | 32K clock| | |----->|gate|-----------> | osc | XBYP | | +----+ RTXOUT --->| |----->| / +----------+ ,/ Thank you, Claudiu Beznea > > Best regards, > Krzysztof >