From: Tariq Toukan <tariqt@mellanox.com>
To: Bhumika Goyal <bhumirks@gmail.com>,
julia.lawall@lip6.fr, tariqt@mellanox.com,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/mlx4_core: make mlx4_profile const
Date: Thu, 24 Aug 2017 12:04:32 +0300 [thread overview]
Message-ID: <ac5b8b4a-edf3-604b-63c5-5ff645e0c5bc@mellanox.com> (raw)
In-Reply-To: <1503492459-3110-1-git-send-email-bhumirks@gmail.com>
On 23/08/2017 3:47 PM, Bhumika Goyal wrote:
> Make these const as they are only used in a copy operation.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> drivers/net/ethernet/mellanox/mlx4/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
> index 541ce9e..43fb2eb 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/main.c
> @@ -121,7 +121,7 @@
> DRV_NAME ": Mellanox ConnectX core driver v"
> DRV_VERSION "\n";
>
> -static struct mlx4_profile default_profile = {
> +static const struct mlx4_profile default_profile = {
> .num_qp = 1 << 18,
> .num_srq = 1 << 16,
> .rdmarc_per_qp = 1 << 4,
> @@ -131,7 +131,7 @@
> .num_mtt = 1 << 20, /* It is really num mtt segements */
> };
>
> -static struct mlx4_profile low_mem_profile = {
> +static const struct mlx4_profile low_mem_profile = {
> .num_qp = 1 << 17,
> .num_srq = 1 << 6,
> .rdmarc_per_qp = 1 << 4,
>
Thanks Bhumika.
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
next prev parent reply other threads:[~2017-08-24 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 12:47 Bhumika Goyal
2017-08-24 9:04 ` Tariq Toukan [this message]
2017-08-24 19:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac5b8b4a-edf3-604b-63c5-5ff645e0c5bc@mellanox.com \
--to=tariqt@mellanox.com \
--cc=bhumirks@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®