From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Marco Nenciarini <mnencia@kcore.it>
Cc: "Daniel Scally" <djrscally@gmail.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Hans de Goede" <johannes.goede@oss.qualcomm.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 3/4] platform/x86: int3472: Parameterize LED con_id in registration
Date: Thu, 2 Apr 2026 15:58:00 +0300 [thread overview]
Message-ID: <ac5n2DzT-TruO8SZ@ashevche-desk.local> (raw)
In-Reply-To: <20260401203638.1601661-4-mnencia@kcore.it>
On Wed, Apr 01, 2026 at 10:36:37PM +0200, Marco Nenciarini wrote:
> Add a con_id parameter to skl_int3472_register_led() to allow callers
> to specify both the LED name suffix and lookup con_id instead of
> hardcoding "privacy". This prepares for registering additional LED
> types with different names.
>
> While at it, rename the privacy LED's GPIO con_id from "privacy-led"
> to "privacy" in int3472_get_con_id_and_polarity() and pass it
> directly to skl_int3472_register_led(), reducing churn when adding
> new LED types.
>
> No functional change.
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
> Signed-off-by: Marco Nenciarini <mnencia@kcore.it>
> ---
>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Hans de Goede <johannes.goede@oss.qualcomm.com>
Just for the information, if you got a tag from a person from Cc list, no need
anymore to have a Cc entry, any official tag is also considered as "Cc to ...".
But it's quite minor, duplications are usually got resolved also by tools.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-02 12:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 20:36 [PATCH v8 0/4] platform/x86: int3472: Add support for GPIO type 0x02 (IR flood LED) Marco Nenciarini
2026-04-01 20:36 ` [PATCH v8 1/4] platform/x86: int3472: Use local variable for LED struct access Marco Nenciarini
2026-04-01 20:36 ` [PATCH v8 2/4] platform/x86: int3472: Rename pled to led in LED registration code Marco Nenciarini
2026-04-01 20:36 ` [PATCH v8 3/4] platform/x86: int3472: Parameterize LED con_id in registration Marco Nenciarini
2026-04-02 12:58 ` Andy Shevchenko [this message]
2026-04-01 20:36 ` [PATCH v8 4/4] platform/x86: int3472: Add support for GPIO type 0x02 (IR flood LED) Marco Nenciarini
2026-04-02 12:59 ` Andy Shevchenko
2026-04-03 10:27 ` Hans de Goede
2026-04-10 16:28 ` [PATCH v8 0/4] " Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac5n2DzT-TruO8SZ@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=djrscally@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=johannes.goede@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mnencia@kcore.it \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®