mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: Dawei Chien <dawei.chien@mediatek.com>,
	Javi Merino <javi.merino@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Tiffany Lin <tiffany.lin@mediatek.com>,
	CK Hu <ck.hu@mediatek.com>,
	Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Minghsiu Tsai <minghsiu.tsai@mediatek.com>,
	Yong Wu <yong.wu@mediatek.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	"moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" 
	<linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: mt8173: Fix cpu_thermal cooling-maps contributions
Date: Fri, 13 Jan 2017 16:36:17 +0100	[thread overview]
Message-ID: <ac6266a7-b540-8fdd-7ece-ef4871cceaae@gmail.com> (raw)
In-Reply-To: <20170113023006.150845-1-djkurtz@chromium.org>



On 13/01/17 03:30, Daniel Kurtz wrote:
> According to [0], the contribution field for each cooling-device express
> their relative power efficiency. Higher weights express higher power
> efficiency.  Weighting is relative such that if each cooling device has a
> weight of 1 they are considered equal. This is particularly useful in
> heterogeneous systems where two cooling devices may perform the same kind
> of compute, but with different efficiency.
>
> [0] Documentation/thermal/power_allocator.txt
>
> According to Mediatek IC designer, the power efficiency ratio between the
> LITTLE core cluster (cooling-device cpu0) and big core cluster
> (cooling-device cpu1) is around 3:1 (3072:1024).
>
> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
> ---
>  arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

applied, thanks.

> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index 12e702771f5c..9a3b0d20f7a8 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -182,12 +182,12 @@
>  				map@0 {
>  					trip = <&target>;
>  					cooling-device = <&cpu0 0 0>;
> -					contribution = <1024>;
> +					contribution = <3072>;
>  				};
>  				map@1 {
>  					trip = <&target>;
>  					cooling-device = <&cpu2 0 0>;
> -					contribution = <2048>;
> +					contribution = <1024>;
>  				};
>  			};
>  		};
>

      reply	other threads:[~2017-01-13 15:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13  2:30 Daniel Kurtz
2017-01-13 15:36 ` Matthias Brugger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac6266a7-b540-8fdd-7ece-ef4871cceaae@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=andrew-ct.chen@mediatek.com \
    --cc=catalin.marinas@arm.com \
    --cc=chunfeng.yun@mediatek.com \
    --cc=ck.hu@mediatek.com \
    --cc=dawei.chien@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=djkurtz@chromium.org \
    --cc=hans.verkuil@cisco.com \
    --cc=javi.merino@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=minghsiu.tsai@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=tiffany.lin@mediatek.com \
    --cc=will.deacon@arm.com \
    --cc=yong.wu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome