From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8BB528643C for ; Thu, 2 Apr 2026 15:43:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775144586; cv=none; b=OOOf0qgcHbqPdRWDIqigvwoBVbtEZWI5lRXwDLUUDcjNK0rl7t1HwmxkM5mboDd1UIwuAEPNMrXVUfSbCBL2zhYPGgwMLksQwkqItzainPw8bi17jl0SXY1JAMrlNR0X42m1y7y92v0EHdcMT7vp//+3k8KG2rM6/a1gs3y31FM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775144586; c=relaxed/simple; bh=Ttn2yRu3wwtLgN5qFTJ6ra4cJ3gSMGCUdUzCTd3RmaM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=J3PSY5yYPJoEJ7+gMKcH0ZtqEkyTmgEKom+FvwMiLmZSj/HoNJ04eDkOwzjTwYLrF9RwTUq7Om04vlPWyt2X/bhDzrayfuELtHJLWajDNDECWoVC2BeQy9JKsAY3ZQOmOswfC34b2daOyJnDCXGNyEQzwzlA5ZoK8JFROM6Cuyc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=nU/cITKt; arc=none smtp.client-ip=209.85.210.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="nU/cITKt" Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-7d4c383f2fcso969381a34.0 for ; Thu, 02 Apr 2026 08:43:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1775144584; x=1775749384; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Re66h9KNwZ6Fa0uoAF0Ox2fmzRwioposUrnLSowRmsk=; b=nU/cITKtrhV99uZdRjmVIH/R1t35A63rQg1nbfhXykRbHGdxlfLQrvhGN5F3wya2l8 J1in1uVRYWu+Y5R7zz0Vd1CPmzhJGCNWta/dot4bBOsKruVCauNhapBmzIKOJDPewwXZ DI6hufw2mkkbTXlcWaWShXaNJW0qZoOvGGuxCrgGrgS/JN7qhe1rs2rTIJHjkR23Je4U BYPv2vwM/kFX4WY60INAHMUnJziX3fTP5f4iBEAUZEXihG+wiBo0Y00PntlbDgGCiTNE mwCyFyettYpj9K8uWsZyp7UCVUiIraYiZkpB3kTTXBA8vbcJOSfpwXp/Xb3oDaEhQBUH n01Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775144584; x=1775749384; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Re66h9KNwZ6Fa0uoAF0Ox2fmzRwioposUrnLSowRmsk=; b=pkpHZKZAClP7JmUK2zdqRy2WQuOAu6c43OwBXCmlWghklvoSyJquBPuQhPCr01l+w4 XQ1Di9C6yVj5FDUM7aDruexpd0ij8thqwhrB7ZFFbm86CDbnVp+DddM7x2NEZkm1lgZm g7uxTu+rGvRMgXXU3toVcceEzcuR+n7nVzDr70XvDiYYFZRiefa1wnB6uCrqQDbsPMkx jPoSZaxERsVvQedhjlg5/Rut+I2hceLUwtLESux2ZpdnVul62OK5xyPVTZxwppVEgD/R oRvIbsT3g4g+mAaoVr+LyJZO8hrJjwHCk9l9rdfbkComb7s+87eeKlEhbMcNgGYB8sFM 6Nvg== X-Forwarded-Encrypted: i=1; AJvYcCWkDdz1pCr94/h53uEoQV4gLLZf1CnSPA2I1K7CFrKBgYr9ZV6hACsuVmnxa/KWfSeFj2IJZefcUHEhv68=@vger.kernel.org X-Gm-Message-State: AOJu0Yw66beDkIfQgat26J2c6U94T+OhhV5ATEXSKX/T8j/TOD1tyAQX NE1LppbMAW+18nLSVPAsIoxg8H5IeIkfwCTCdCCclYsn1int5/GyIxuw8jTfYe25LIo= X-Gm-Gg: ATEYQzwpwO2UaafOLk+eC2uaq02+QFQcshuaDdwSWomtX2CXEvU/SjxClzzyAY256L2 NaNdxvthluccosWD7/NxZgZaMOeSPdY2xj7t31EmJJK1EpcoiOwVCIVuFSI8vTtRSxrYyYXqFiM qycmDh+UmXHY2R8SIHKWkcBt5QK5kSpr5txsQ8kY4MiNB9lsZY8Fe9hmhSOjJVBexKOG8fX/VnT /D9A6sR9OsJ9tbFpycDqciwLUbC7sIrY74ybGsMcB3vbocnChynixNBXkkPJCNMJWs/1nVUHdWT 1eGgZVuhJlYunHAiEKzONHxEQeb1+HNDR3TmcpYm17lno6+O5N7Vfu5f05gslBS1JxY3Tt+dOFf Yb9uDgSC5550Lzx31t2RCk+b4DaEGodSJRducyP+KeXt0n+reKFB5tx90yU/Kba4W51nozIjAng Auzu6trkaDeHKCNx04zYt36DHSxb0vTwLAPiKgpYTFU/yvfLJ1Vi4H+/Y2Qi1lZTLwYrbhJhmqh MWrLGe8WCbFtIBmLheEbuXDZA== X-Received: by 2002:a05:6830:6b09:b0:7d7:b6b2:607e with SMTP id 46e09a7af769-7db991ed625mr4935431a34.5.1775144583724; Thu, 02 Apr 2026 08:43:03 -0700 (PDT) Received: from mail.minyard.net ([2001:470:b8f6:1b:d6c6:4627:14b5:9503]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7dba7159fd9sm2340173a34.7.2026.04.02.08.43.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 08:43:03 -0700 (PDT) Date: Thu, 2 Apr 2026 10:42:59 -0500 From: Corey Minyard To: Jian Zhang , Quan Nguyen Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [Openipmi-developer] [PATCH 1/5] ipmi: ssif_bmc: cancel response timer on remove Message-ID: Reply-To: corey@minyard.net References: <20260402110435.3589408-1-zhangjian.3032@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260402110435.3589408-1-zhangjian.3032@bytedance.com> On Thu, Apr 02, 2026 at 07:04:31PM +0800, Jian Zhang via Openipmi-developer wrote: > The response timer can stay armed across device teardown. If it fires after > remove, the callback dereferences the SSIF context and the i2c client after > teardown has started. > > Cancel the timer in remove so the callback cannot run after the device is > unregistered. This whole series looks good to me, and I have added it to my next tree. I'd like to hear from Quan, though. -corey > > Fixes: dd2bc5cc9e25 ("ipmi: ssif_bmc: Add SSIF BMC driver") > Signed-off-by: Jian Zhang > --- > drivers/char/ipmi/ssif_bmc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c > index 7a52e3ea49ed..348e29490945 100644 > --- a/drivers/char/ipmi/ssif_bmc.c > +++ b/drivers/char/ipmi/ssif_bmc.c > @@ -843,6 +843,7 @@ static void ssif_bmc_remove(struct i2c_client *client) > { > struct ssif_bmc_ctx *ssif_bmc = i2c_get_clientdata(client); > > + del_timer_sync(&ssif_bmc->response_timer); > i2c_slave_unregister(client); > misc_deregister(&ssif_bmc->miscdev); > } > -- > 2.20.1 > > > _______________________________________________ > Openipmi-developer mailing list > Openipmi-developer@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openipmi-developer