From: Jens Axboe <axboe@kernel.dk>
To: Breno Leitao <leitao@debian.org>,
asml.silence@gmail.com, io-uring@vger.kernel.org
Cc: leit@fb.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] io_uring: One wqe per wq
Date: Fri, 10 Mar 2023 13:38:20 -0700 [thread overview]
Message-ID: <ac6a2da7-aa88-b119-6a44-01d2f2ec9b6d@kernel.dk> (raw)
In-Reply-To: <20230310201107.4020580-1-leitao@debian.org>
On 3/10/23 1:11 PM, Breno Leitao wrote:
> Right now io_wq allocates one io_wqe per NUMA node. As io_wq is now
> bound to a task, the task basically uses only the NUMA local io_wqe, and
> almost never changes NUMA nodes, thus, the other wqes are mostly
> unused.
What if the task gets migrated to a different node? Unless the task
is pinned to a node/cpumask that is local to that node, it will move
around freely.
I'm not a huge fan of the per-node setup, but I think the reasonings
given in this patch are a bit too vague and we need to go a bit
deeper on what a better setup would look like.
--
Jens Axboe
next prev parent reply other threads:[~2023-03-10 20:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 20:11 Breno Leitao
2023-03-10 20:38 ` Jens Axboe [this message]
2023-03-11 20:56 ` Pavel Begunkov
2023-03-11 22:13 ` Jens Axboe
2023-03-13 3:56 ` Pavel Begunkov
2023-03-15 20:44 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac6a2da7-aa88-b119-6a44-01d2f2ec9b6d@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=leit@fb.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®