mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Lukas Larson <lukaslarson@gmail.com>
Cc: mchehab@kernel.org, hverkuil+cisco@kernel.org,
	johannes.goede@oss.qualcomm.com, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: ipu-bridge: Add upside-down sensor quirk for Dell 16 Premium DA16250
Date: Thu, 2 Apr 2026 19:39:17 +0300	[thread overview]
Message-ID: <ac6btfUsok-Y0Dw2@kekkonen.localdomain> (raw)
In-Reply-To: <20260331190145.11592-1-lukaslarson@gmail.com>

Hi Lukas,

Thanks for the patch.

On Tue, Mar 31, 2026 at 09:01:43PM +0200, Lukas Larson wrote:
> On the Dell 16 Premium DA16250 laptop, the camera sensor (OVTI02C1) is
> mounted upside-down, resulting in a flipped image in userspace
> applications.
> 
> Add this model to the upside_down_sensor_dmi_ids list to provide the
> necessary 180-degree rotation quirk so the image is oriented correctly.

Could you try if these
<URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=pld> fix your
issue as well?

There are a bunch of Dell laptops with this sensor and only some of them
need this quirk...

> 
> Signed-off-by: Lukas Larson <lukaslarson@gmail.com>
> ---
>  drivers/media/pci/intel/ipu-bridge.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c
> index 32cc95a766b7..ec2056c268de 100644
> --- a/drivers/media/pci/intel/ipu-bridge.c
> +++ b/drivers/media/pci/intel/ipu-bridge.c
> @@ -104,6 +104,13 @@ static const struct ipu_sensor_config ipu_supported_sensors[] = {
>   * without reporting a rotation of 180° in neither the SSDB nor the _PLD.
>   */
>  static const struct dmi_system_id upside_down_sensor_dmi_ids[] = {
> +	{
> +		.matches = {
> +			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell 16 Premium DA16250"),
> +		},
> +		.driver_data = "OVTI02C1",
> +	},
>  	{
>  		.matches = {
>  			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."),

-- 
Kind regards,

Sakari Ailus

  reply	other threads:[~2026-04-02 16:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 19:01 Lukas Larson
2026-04-02 16:39 ` Sakari Ailus [this message]
     [not found]   ` <CAMCiyfoVxS_iQWVEiak+mv1i9uF2WtqMqyfCgeQyO_q5XS4LgA@mail.gmail.com>
2026-04-07 12:33     ` Sakari Ailus
2026-04-08  6:02       ` Lukas Larson
2026-04-08 11:11         ` Sakari Ailus
2026-11-04 17:32 ` Gabriele Gamba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac6btfUsok-Y0Dw2@kekkonen.localdomain \
    --to=sakari.ailus@linux.intel.com \
    --cc=hverkuil+cisco@kernel.org \
    --cc=johannes.goede@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lukaslarson@gmail.com \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®