From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A5D8374745 for ; Thu, 2 Apr 2026 18:12:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775153544; cv=none; b=PRZRUOh+p4WFRSmPceAvjjKU0Ldurshs9QQ6upcO7VjdLbzyHrN1hhwmKh7kf8tpl6rGaQ1rfpwAr2P8AJqZ99yolhEAHXop8I93OHsvY+qmmsqL+3e8zHFWNokUoXmAozUNu3lFdg1w/AJi1irYTuQbdhYLud9xMRvcoHlflgE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775153544; c=relaxed/simple; bh=/pNKs7teCd1eSDB/AA3D8brUZ1+usjFyoX9rIah13XU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k+0V8NLL4i9zbMdb5TWrgzcQ9fLkBB8F7ZotbHTGv9yw1eLCFcimyaIaXqWdGNlAJsiR9k4+FRd2meXDJk5vw9kwHD0Ob9KQb564ziiSuNG0rfCXbtHRoGIfkqJQo0rAz0+WJx8s5vM793XJPyIoLCaKjsn0ax+ENkA6FzcQMWU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Iy/hAM3p; arc=none smtp.client-ip=209.85.221.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Iy/hAM3p" Received: by mail-vk1-f173.google.com with SMTP id 71dfb90a1353d-56d93355337so872004e0c.0 for ; Thu, 02 Apr 2026 11:12:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775153542; x=1775758342; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=THRacyHIXkYei7b/MZ9La6/OBKYyMj5xj+E8oeLw97I=; b=Iy/hAM3pGytqMXgUOeg5BRIL/9flTR2ms9A/+0NHsw/WXkmnExKjfbCD6kP/xP/+9W TtF5QG6gr4xU6so1D2nZEsK9a9qrsfnsVktYnu97LXHufLZqYoupST/QG6ni1HpmcCaU agAT+bmxSf8vc6Idq4/GsPdD4Mw4isutAn/szvgnj2KTGqmQHzuuHWLQW/8HXLqUMJhv AzjHhkCEmR4D6ZJXfgB4BOASxBPKgeNuKGRTsyYTouKUyMlJQ3kZaBDWjL4jsA0rrUZZ fDZLR0Xdl86DpgoX2n2I0DiYJP3AVfkwMxtqVYIqrSwmWiKjzqKPinU3YU+LNGmdQxnE zdSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775153542; x=1775758342; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=THRacyHIXkYei7b/MZ9La6/OBKYyMj5xj+E8oeLw97I=; b=nBjP9rArQ2g1Ra50tPH+wSnBVoWTK9TEAPH6R4fD0Jz7+tKwLnNrQ6yNjEefsY5QEY 2mbpNONOUq9q7AukOFb0XVdJo1yQzWhRta9sZ1ONicT+GfNk+xNAj7r461nNTOMRLGVm eV0LQOQNOp5XLNjP7YZXweK1A3O6v5EsUD/kADDm9tYemes4zmdkFhNcrC1MkFE4bHFz bnccZlnM1A4jIdmzNkNzHLiKP8LQbyriEN7BHTKEIEKmgpTXfxemWkUsyzgQiAv/WVQ0 yjE0IZOHAHi03Jl6DG4WLzjF3sbsbmzaTW4hYl5i3XjboxFazXahayQErOE2sI0ieaok OpAA== X-Forwarded-Encrypted: i=1; AJvYcCVM8I8Q3der9Kfz8B3GKvz4rgZ998ZA3zvk1WG57w1OtUT1BqwGwGVswzFObx9C0wM2UH9009aftwFNCLc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7YFXf5FEN5jk3cTT4g/nYVVq57pMINzEVOZ5bdnLQZxLOARDB aoBrJfP2wnFLK1GRUtug4zUsQ4r/AC1zBm7DEI5qjaLDj2kOK2fGdkuz X-Gm-Gg: ATEYQzwabRgcOWxJ2s+T9iCoUSnQNMk+IG7dPAu3/IgkEw13Tdf9MEGgOuDFiCWw5cK U8+VY3FJdiaA5bPx5tSsQ5OEsurkOMgTx6B+0ykypOwKGi7Q/pwKr/ivJ2LSbPQSl/D81pWbpeM zULWY9H2gTnfeYW8cxDbJaCqXxkQpVdBh+s1qGXEMMX941RSP/WrjwkprnOj/Q34PJgP4LhsTRH GhapLbBowRnXpxeL2C8oRW26FSGrS5dRsK3GuKFi1DzYSFTDzJS0Dyc/gJtKcDr5EgK3nwBqmkK zeV8MwxAwU9eIehW2hwdA5dz7jRgWwm0IIxhvgUijHRDwMLS4XIU4uRKZZq+oYbn9XSv2c92SNi +VCuk/jcbi+coZx4XNzeagUozdN2g722yxeajOhjZdkHY0F01MnWK6v2WkqnvXs0XtXhqniZA7t /A3ztEZ+jx+oBNzfR/l6GLum+IktUzDDOLxI4Rv2oS0fTKpmQ= X-Received: by 2002:a05:6123:149:b0:56b:579c:82e with SMTP id 71dfb90a1353d-56dab8805ffmr50865e0c.5.1775153542079; Thu, 02 Apr 2026 11:12:22 -0700 (PDT) Received: from localhost ([2804:14c:5bc6:8c1b:8512:ab64:bee:7831]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56d9bc9cbbasm4491588e0c.9.2026.04.02.11.12.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 11:12:21 -0700 (PDT) Date: Thu, 2 Apr 2026 15:12:18 -0300 From: =?iso-8859-1?Q?Jos=E9?= Guilherme de Castro Rodrigues To: Corentin Chary , "Luke D. Jones" , Denis Benato , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] platform/x86: asus-wmi: fix camera key led on Zenbook S14 Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Mar 31, 2026 at 08:01:47PM -0300, José Guilherme de Castro Rodrigues wrote: > > This change is not visible to userspace, as no sysfs attribute for > ASUS_WMI_DEVID_CAMERA_LED_NEG exists. > > + if (is_camera_toggle(code) && asus->camera_neg_led_available) { > + camera_neg_led_trigger_update(asus); > + return; > + } > + > if (!sparse_keymap_report_event(asus->inputdev, code, > key_value, autorelease)) > pr_info("Unknown key code 0x%x\n", code); This change is actually visible to userspace because I'm early returning and that means the event for the camera key is not propagated to userspace. Sashiko correctly identified that, as well as another detail in formatting (using space instead of tab for indentation on the newly added macros). The event is currently not used on my system, so I didn't notice it before. Removing the return fixes this. I can send a new version of the patch if necessary. Best Regards, José Rodrigues