mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Felix N. Kimbu" <felixkimbu1@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: cfg80211: Remove parentheses prism2_get_station
Date: Mon, 11 Mar 2024 17:09:41 +0300	[thread overview]
Message-ID: <ac756a79-0522-4286-a464-2a62a4fb1cde@moroto.mountain> (raw)
In-Reply-To: <Ze8LBf6xSjCRt4rd@MOLeToid>

On Mon, Mar 11, 2024 at 02:45:41PM +0100, Felix N. Kimbu wrote:
> Remove unnecessary parentheses around 'wlandev->msdstate != WLAN_MSD_RUNNING'
> in static int prism2_get_station(...)
> 
> This change ensures adherence to coding style guidelines.
> 
> Signed-off-by: Felix N. Kimbu <felixkimbu1@gmail.com>
> ---
>  drivers/staging/wlan-ng/cfg80211.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index 471bb310176f..7451fd2bb580 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -247,7 +247,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
>  
>  	memset(sinfo, 0, sizeof(*sinfo));
>  
> -	if (!wlandev || (wlandev->msdstate != WLAN_MSD_RUNNING))
> +	if (!wlandev || wlandev->msdstate != WLAN_MSD_RUNNING)

Sorry, we're ignoring this checkpatch warning.

https://lore.kernel.org/all/?q=prism2_get_station

regards,
dan carpenter


  reply	other threads:[~2024-03-11 14:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-11 13:45 Felix N. Kimbu
2024-03-11 14:09 ` Dan Carpenter [this message]
2024-03-11 17:05 ` Julia Lawall
2024-03-11 19:12   ` Philipp Hortmann
2024-03-11 20:46     ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac756a79-0522-4286-a464-2a62a4fb1cde@moroto.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=felixkimbu1@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®