From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C0FF15ADB8; Wed, 28 Aug 2024 20:45:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724877941; cv=none; b=iRJTH9F3Xys0nEDKS2mJubE01/kHptX2vMPRCKs+/1XTdkIAKzR/xVEf4jUaa11+QtI5dxGN++I3TxUF4Gljd8X/bK5iNEjo0lFee7zDTIw6sNPBcNznyv2OqKV+t6NGUNcwyeXz1fq/TB/6Z3Yrww5ypjLrdVSkDS1dPR6B2vs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724877941; c=relaxed/simple; bh=SgkVzbZ14XDCKU36J6WIIsAV8YesujpxnFyHSFaz29I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hlJIQKs/eri4jxiOjUG/ZS8dapx6GZxt67q0SIPZWFmSZj1v1coPNPefngH1UafusQcRJu0+recOF9bmmRkDEYS37zX04FpIMimbBB0pp7ounfBtUXtjuTG3eGEGm7L+u6+3Up3eTB9BQS6s0Pso0mfAK0nAMxOTxzqm5Yf8DF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=OKQgy4ys; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="OKQgy4ys" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=26bQlRFk72rfSBekGYpkyGTtRJqwYyFZxRzNApkdSOw=; b=OKQgy4ysRnacVUQNcvrpOFp0SO LP6MhA9Y051p7GyB8Tp6/9SoSV1bVKBHABXj65p6vM8XvjsX6MG4hLS/hnOQ9RWujM28wSrjNmPrC sVXVOx1upE+wWFfv4ZXyIWsmMZwKIOrhflCWBr8H/eywcwgvt8qNeD98pXr5fTpMi8TY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1sjPXo-005yGF-EH; Wed, 28 Aug 2024 22:45:32 +0200 Date: Wed, 28 Aug 2024 22:45:32 +0200 From: Andrew Lunn To: Jakub Kicinski Cc: Oleksij Rempel , netdev@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, Eric Dumazet , kernel@pengutronix.de, Paolo Abeni , "David S. Miller" , Heiner Kallweit Subject: Re: [PATCH net-next v3 1/3] phy: open_alliance_helpers: Add defines for link quality metrics Message-ID: References: <20240822115939.1387015-1-o.rempel@pengutronix.de> <20240822115939.1387015-2-o.rempel@pengutronix.de> <20240826093217.3e076b5c@kernel.org> <4a1a72f5-44ce-4c54-9bc5-7465294a39fe@lunn.ch> <20240826125719.35f0337c@kernel.org> <20240827113300.08aada20@kernel.org> <20240828133428.4988b44f@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240828133428.4988b44f@kernel.org> On Wed, Aug 28, 2024 at 01:34:28PM -0700, Jakub Kicinski wrote: > On Wed, 28 Aug 2024 06:50:46 +0200 Oleksij Rempel wrote: > > Considering that you've requested a change to the uAPI, the work has now become > > more predictable. I can plan for it within the task and update the required > > time budget accordingly. However, it's worth noting that while this work is > > manageable, the time spent on this particular task could be seen as somewhat > > wasted from a budget perspective, as it wasn't part of the original scope. > > I can probably take a stab at the kernel side, since I know the code > already shouldn't take me more more than an hour. Would that help? > You'd still need to retest, fix bugs. And go thru review.. so all > the not-so-fun parts > > > > Especially that we're talking about uAPI, once we go down > > > the string path I presume they will stick around forever. > > > > Yes, I agree with it. I just needed this feedback as early as possible. > > Andrew? Do you want to decide? :) I agree about avoiding free test strings. Something more structures would be good. I can definitely help out with review, but i don't have any time at the moment for writing code. Andrew