From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 071C53630B8 for ; Thu, 2 Apr 2026 21:00:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775163603; cv=none; b=AXUbF+RoG2qhDWLLk2SRLR6IzuYMH8we0GnXhSlOGfU8qkEgbbybhhDB6rIxXvb88+IFjI/okFy5EX2bhoalxaPavJuJIznlOObVfuSCNU1HDzpyya8HPyGPC++TVzVQPbO28Cy0oZtxyglLuOuxeuX/QvzC73Zye/KR13UMIxg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775163603; c=relaxed/simple; bh=u54I39wHWUHbDyBdb1+/nfBUiIfO1SJ+AZIT0MAjnsU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IQF45fFgqgm+BbwTF3Y8+dOWodgPkYnTXCi+tn0/myAq0hI2F0VQxc73So8u87uVr54qA318bgMtrevRySohOrtOGCq6ubzIHHUdsB4KtP2jN1MweUAM0IJO9aqbbAT2QGVgtkU1bxfU1oAgMUg2WPcxPEXtCXzhZg6jloWzqus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=QMPkaeDF; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="QMPkaeDF" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-824c9da9928so710323b3a.3 for ; Thu, 02 Apr 2026 14:00:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1775163600; x=1775768400; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=bCpzZqe6/GN8u+eCCZI55uBzEHgmE5Itzy/ezeiV81U=; b=QMPkaeDFoQ+WWZN1aGpnLQJwMkacotRy78374fSVeRHQrjW3V5ll1MbpWxI/HZk4Sq YAsAiLe/A4LcyUIU3ZvTivOazOLmFeZs+YuZBwtn6xh3HbG6Nv70VCBf5+Bv/gPjY4Rh QnC8zoKcgE50G7mvxotJdmYnPhJYmQTetWoN9heJ5HDzZbq6VjqSy7Ip/Vx4a1ZggHP8 RWWFs8G4btex6KLraQ1SUIgvqq8OolP4KKFNd14KlkKmMXPAaUWDln3ygL5VMlGvIbd7 slPmM5rW7PYuxm451RKdYtg80BnKfU9tOQgk5MXLBbNWb8v8cu/c09rr/FlqEwk0G8Ah ps3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775163600; x=1775768400; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bCpzZqe6/GN8u+eCCZI55uBzEHgmE5Itzy/ezeiV81U=; b=CTzv2LpuaErJIhmr4aNQEfFWXHWGeeiQPCtn1WRKWQlNoxA51wHU0ldb4Oa826xOGj UuWuthdWpg8Y+vYWJEnF+/lKf44gwfmi0sjPbznAxqSEOren2D051kHFyHb1DCgyNHvk PcGxRREti4Ne7H75DHZvhN9pXHPHNU56XKPQLmqjh/hzWdh8u1VYcO4ZPrvdcpNsBrfI me+KyjMd+KMs44Z5o4GwSDYWnGPnabgro2jr2iAx7eVGtwPx9jeq7HQtGtMEdw/xExOJ WT6iX4PoY7NnD5QzFiCCCqNSEcnSPhpPDvIFyjHny/xRizCk1gfXbknOAhol67+Mv5eJ RTOg== X-Forwarded-Encrypted: i=1; AJvYcCUhxL46BhLoncM9PoID7rHgTNm9adUqDs5vUOXrlnTYW91z/B+aF9iwgxG6ZM3e353oAPm5n4633nqXzh8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5U5ahwApp9N3cJPxLeR7FNla0d8nrjGq80Q3t0EOD2AKULsVu dX9210bFzST+/cxkBQXucnK+UjSR73t2GfNt4AP8FKEKvthMokBBKTLI2ne4dcXYAmw= X-Gm-Gg: ATEYQzwLL9hWHGE3/WEvt9Xid27s5btqhGx/0naqu8YRYqWIFpveilq1zF+tNZk9Sf+ HqtZcWLqvHPwR0A6bTzr28EeInj0iuenx2yugfdGipWApCZq+L+Mj6xmeHTDRFL2Ky9vSuD9is0 XxaqbA8etYF7ANRT+K5t/K8OTKxOqFMQbwJXqDJMQDZfPNQOf7Am94HQ4qY1su5HoBnQBA2fj6d MbPDKwTZriTdUQ4568lHz7pmrA3IeXTRl29xdO8DnvgRrnba4EXCVe9Z54LZTAIWV5hlj//X0kS xYRTNzZQBV72AFzG9vLJaNknTPVPgl/uaJN2mSAj1aW+YSeY9kfqCcEXn2q9YJ+/d7/Cw1V/Bl9 FEy2PoqdtEQh2XtpVBdnP+TyHVAF5ezuF/yvTf0N6rZhJtpHQAqq6btZx3AfQIAqpTC6RL33dZ+ MSJn4= X-Received: by 2002:a05:6a00:3902:b0:82c:e816:412f with SMTP id d2e1a72fcca58-82d0da5502fmr501200b3a.18.1775163600420; Thu, 02 Apr 2026 14:00:00 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:2::]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9c6ba2fsm4034726b3a.45.2026.04.02.13.59.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 13:59:59 -0700 (PDT) Date: Thu, 2 Apr 2026 13:59:59 -0700 From: Joe Damato To: David Carlier Cc: horatiu.vultur@microchip.com, UNGLinuxDriver@microchip.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] net: lan966x: fix page_pool error handling in lan966x_fdma_rx_alloc_page_pool() Message-ID: Mail-Followup-To: Joe Damato , David Carlier , horatiu.vultur@microchip.com, UNGLinuxDriver@microchip.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260402172823.83467-1-devnexen@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260402172823.83467-1-devnexen@gmail.com> On Thu, Apr 02, 2026 at 06:28:23PM +0100, David Carlier wrote: > page_pool_create() can return an ERR_PTR on failure. The return value > is used unconditionally in the loop that follows, passing the error > pointer through xdp_rxq_info_reg_mem_model() into page_pool_use_xdp_mem(), > which dereferences it, causing a kernel oops. > > Add an IS_ERR check after page_pool_create() to return early on failure. > > Fixes: 11871aba1974 ("net: lan96x: Use page_pool API") > Cc: stable@vger.kernel.org > Signed-off-by: David Carlier > --- > drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Joe Damato