From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: Alex Shi <alex.shi@linux.alibaba.com>
Cc: Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] OCFS2: use OCFS2_SEC_BITS in macro
Date: Sun, 26 Jan 2020 09:47:06 +0800 [thread overview]
Message-ID: <ac7f6b5e-f62a-38a8-2511-e254c282e012@linux.alibaba.com> (raw)
In-Reply-To: <1579577840-251956-1-git-send-email-alex.shi@linux.alibaba.com>
On 20/1/21 11:37, Alex Shi wrote:
> This macros should be used as it.
>
> Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
> Cc: Mark Fasheh <mark@fasheh.com>
> Cc: Joel Becker <jlbec@evilplan.org>
> Cc: Joseph Qi <joseph.qi@linux.alibaba.com>
> Cc: ocfs2-devel@oss.oracle.com
> Cc: linux-kernel@vger.kernel.org
Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> fs/ocfs2/dlmglue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
> index cda1027d0819..0d6daf49b72a 100644
> --- a/fs/ocfs2/dlmglue.c
> +++ b/fs/ocfs2/dlmglue.c
> @@ -2133,7 +2133,7 @@ static void ocfs2_downconvert_on_unlock(struct ocfs2_super *osb,
> }
>
> #define OCFS2_SEC_BITS 34
> -#define OCFS2_SEC_SHIFT (64 - 34)
> +#define OCFS2_SEC_SHIFT (64 - OCFS2_SEC_BITS)
> #define OCFS2_NSEC_MASK ((1ULL << OCFS2_SEC_SHIFT) - 1)
>
> /* LVB only has room for 64 bits of time here so we pack it for
>
prev parent reply other threads:[~2020-01-26 1:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 3:37 Alex Shi
2020-01-26 1:47 ` Joseph Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac7f6b5e-f62a-38a8-2511-e254c282e012@linux.alibaba.com \
--to=joseph.qi@linux.alibaba.com \
--cc=alex.shi@linux.alibaba.com \
--cc=jlbec@evilplan.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®