From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8B32285072 for ; Wed, 20 May 2026 15:36:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779291365; cv=none; b=Izj9ZTdJPDOqYyOYu4nXXIKadYGhUNxZhpQiLyVZTaACnpu/gPc9QfDkgKiU0Ns1bFg8fNSg4Lo57thS9cxfw7ewH5IYkbC9unu5UCQDIUalnlqyUl8qm32g/8Ik4HUKBzhOGRRgcREfxMY+N1ajY+Kgz50mMwsSy7bhxCans5o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779291365; c=relaxed/simple; bh=grK9Sk8iW6KUeMq1UrYciHs9/Q7D0/UySExNCSNTiQ8=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=XscjpzZ+IorklFtQpQc5T/PdkePKXzuAaolc92/1k4vtgF8qArlx67XHBmacQsPOjOEsim22O9/XfXAzX+w9X7FX/X+iVFocQ2Fqs7hnGf8OPZjFEY6bXIEoDDMmnWwyrRBVuHEagdPqVt6EtzNFEe5yXDLKKl7tjKOAUizweGg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KrSuBNrw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HLqIdMs6; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KrSuBNrw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HLqIdMs6" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64K9o314448311 for ; Wed, 20 May 2026 15:36:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LX1bOj+G5ahWYvZvTeBmcr/OlqkTeJDTD2IiN0zQbbc=; b=KrSuBNrwaiehvrIO FzTZf4Mvww0VyNu9V5D4NyMEDGhu1qWedER7p6bsNk9xKzqr788drW8gbj7DikpG IkvNtyUhGUcioPl0c9vKtl259ZgHUiOMnNid7ZTv7DB0KzxOuk4tTY/tD+KcnbYr 9orpsnPHESIWm34aGkYt3LveZXn/KGnwyDSwGmw4rNGE8soOwoaIL+wt0RWM5H0a y5feACtKhuUSOnM8EiMhE4WXE5LZ8YC/Kn1bMKc7ulsCy14Nm1tzuowbdd7q07WC 7Lc30xmVze/B5WXjuSQb2JeaRkbkQyNHuCQtmq4DZmvZZyKLsb/3U1gFuYy25Hkc VrM3eg== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9anrhb11-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 20 May 2026 15:36:02 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-6322654bb6eso8716516137.3 for ; Wed, 20 May 2026 08:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779291362; x=1779896162; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=LX1bOj+G5ahWYvZvTeBmcr/OlqkTeJDTD2IiN0zQbbc=; b=HLqIdMs65WdwWWpdQXf4q+ouPcm+hNaRkNsXu9hozefZ/xNSSd63tTMEUIxEGvjx68 ypBdPxWaWY4VRPSYpy4Gc1RX4TjeiSopK7bywB5jeQqgZpKsafckjcZy1x201fukhjeg zH/81ChuEZi6zSqVoLoQ4y3X3bB8jgX9jDiFvDMEa6zuMyvBD006VeGbVq50yZd+jzWQ ZacyvlU6HtjmJHrLC1Mj8aMciNfCfkytg568IT8T3oO43/VIRGDfcnKxnNylxluJ0xo9 F+S713mNUct8g2HnPJFXZCbUtCqhZRnURXFZcgEFyzhhXx9fFjtU4GSfebxsrRr+FfQ+ ubeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779291362; x=1779896162; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LX1bOj+G5ahWYvZvTeBmcr/OlqkTeJDTD2IiN0zQbbc=; b=YwWeyDA4bIygc9cy0ETdIu3FD/vFCGmgaGM36oUZIUECVO4khEGU62xW2r388QJCC7 rP1SwBxseR8FFuzeDw8+C/O8BSVAFFdS2hdNEybZfzngpa/5H5AtVRq87JBhJ5EVTfEe QEF+1TdMYGA3WbAZXCRyzwidzFM/G3il1LNQ2LHbUQuSA5g6TTIhlrxY2Gd652GpPD4c xtfL5lOZzBSH+ItH/675j/yG+s+zFTbzH4Yij1vt1pHjbjlQkKSngaVhGM7MTvF9DfRV gq6OwDF/bS19pY0nMtyf9H8ZNg4R9q0nM2FnkmDRDoGJ+VSf4lmuLiMmM5+GYGyrtZWr vu2A== X-Forwarded-Encrypted: i=1; AFNElJ+w8M+FtAxQPAhB/zelsEEUQ08efDVpk1eo9cH65ZSxcfbg3S2qM7829pbLMfgG9qV64Rjfif8YQCWu7d4=@vger.kernel.org X-Gm-Message-State: AOJu0Yyt88T+2dxDNGazBL16L9TBvDiQ2NNpLlH6/WQWURYvWYPYp+wk EeXitPZEEXgXuuOJ6XSZ7mlvYdoTxUQPkYcsi1A8rrdRyuzqu7lMb0leMTKHnYtPvpTAc7grLmG PDSSPNwPt0K1KZjseqVFZHPDoA+/Q3PxXNDC6iM3554RhQa4EFZgWTSHnHVWxRkUmHSQ= X-Gm-Gg: Acq92OFiYc2byX+LqaKhP6n2Y2RAZKRl2lpPFIbDwaIkjVzft9SHAu07XKulso3FnuJ zpzWdv5jYp5fdzS+62SCfX7bQZ4N5lqtIxr7PrNvQUynAwITHIZrQE5IuJ99hPZ7BQlIb4+wg2d xllK3m3CrUosNjK5apmZYiB3LgejKlbLLojNzXVWdzmc4X/ccli6WDI2jfM/CWU4kJ5NqfVD23m rhlqEb0jlHPNBG7maXtP6JoHP4/jxE6FJijSj5xLpsdSDqkMI9Vy8U06V1PUeCy1zCCQHyYOfvi SDTlOBwicoueWIu/POL06IexvdxSc7NlkBN7/02c2YF98xsBIPj3sdPXhKdzlXdHtLq0yeGSX8J KfHMPPYO9WB1Pl1VFEcKoABPITTPC/s1aIs17rZEqBbkMUYMT6dULZa89U3sCJ3gXALRmVgfnk7 q3GD0cr+MsVB5nY82ka2UB9hOZjtOXT0gu9Ydt/Tm7+xdu9r+zUaMMZnu+4g5wHITOjPl5dXntC qGjmLVQ7QNjmviA X-Received: by 2002:a05:6102:548c:b0:637:ad7:f57 with SMTP id ada2fe7eead31-63a3f79362amr12682855137.25.1779291361559; Wed, 20 May 2026 08:36:01 -0700 (PDT) X-Received: by 2002:a05:6102:548c:b0:637:ad7:f57 with SMTP id ada2fe7eead31-63a3f79362amr12682800137.25.1779291360918; Wed, 20 May 2026 08:36:00 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bd4f4e60a76sm871298766b.53.2026.05.20.08.35.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2026 08:35:59 -0700 (PDT) Message-ID: Date: Wed, 20 May 2026 17:35:58 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 13/15] media: qcom: camss: Add CAMSS Offline Processing Engine driver From: Hans de Goede To: Loic Poulain , Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , Kees Cook , "Gustavo A. R. Silva" , Bryan O'Donoghue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, devicetree@vger.kernel.org, laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com References: <20260508-camss-isp-ope-v3-0-bb1055274603@oss.qualcomm.com> <20260508-camss-isp-ope-v3-13-bb1055274603@oss.qualcomm.com> <3f75dd6a-96d8-4feb-b44c-39c8f5d3492b@oss.qualcomm.com> Content-Language: en-US, nl In-Reply-To: <3f75dd6a-96d8-4feb-b44c-39c8f5d3492b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 8jpjBkjTPGXHveRA-skq-qu9K6-wuwHO X-Proofpoint-ORIG-GUID: 8jpjBkjTPGXHveRA-skq-qu9K6-wuwHO X-Authority-Analysis: v=2.4 cv=UuJT8ewB c=1 sm=1 tr=0 ts=6a0dd4e2 cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=4MUlk2DU2KS13UTX2eQA:9 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIwMDE1MCBTYWx0ZWRfXyAVJLWfjUS86 MvMG74g0I7zE0X8sZQa/otldW6uQbsUxPGfgS+Ou1cr07FjMnPLzkhPstndOY+pr7Ip6oMo6PSn kGW/vy8ZLzTqOHt17LtxPsE3ln2JJd69hE+iHJ9J0VR8LPfrzWEu5JuXcNU7Iik5n1VbS69Tj00 XrE7fuMwdXwd9wA5kkFsLCdIqBTwkOj6xsy0tO7/MuoujFTs/35bosBILTuL/KXGlN7fgRYf1jW AgXixYAma9TkSaz/Ig2XnqVhJvAoJJyyZ6bpjozzuusQKVJDQE+0azqsBpBXRUzVTp7drahdggT QCHJx327UsevjB9iZbTuWVV8SD+SSh2ch42Tk+kOW6iya6NmsgCfikYeMMuGLpI4ty9IZeoBmJP 67lpq7FzZpC/3s+ri5szoFryb4/l4aXY3GDOxcdaK5xXiZ2qt4fQvwMFqVWAUy1icoDBQUCHcLl A3LD4hPh/fdAxwm6CCg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 spamscore=0 malwarescore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605200150 Hi All, On 20-May-26 17:32, johannes.goede@oss.qualcomm.com wrote: > 3. Similar to the ope_input /dev/video# to ope_proc pad 0 propagation, > for the try stuff automatically propagating info from ope_proc pad 2 > to ope_disp pad 0 will also not work. In this case it might be best to > just completely disable auto-propagation and rely on userspace to do > this itself even for the active state. Or you could do the > v4l2_subdev_get_locked_active_state() thing again. > > You can check userspace has done this properly by calling > media_pipeline_start() at stream-on time, which ensures that enabled > source -> sink pad links agree on the format on both sides. > You should probably call media_pipeline_start() regardless. Correction this is superseeded by note 6: > 6. There should be no propagation from /dev/video# nodes to pads, instead > a validate_link media-entity op should be used to check userspace has > properly made these line up on stream-start So no propagation from [try|set]_fmt on /dev/video# to subdev pads should happen at all. Regards, Hans (also sorry for not cutting the large rest of the patch in my previous reply)