From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABD09C43381 for ; Mon, 11 Mar 2019 12:22:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 765F32084F for ; Mon, 11 Mar 2019 12:22:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="SIOwzz30" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727264AbfCKMWu (ORCPT ); Mon, 11 Mar 2019 08:22:50 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:53410 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726812AbfCKMWu (ORCPT ); Mon, 11 Mar 2019 08:22:50 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x2BCMYRu022228; Mon, 11 Mar 2019 07:22:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1552306954; bh=Oh/iIegz3Pfq23kPJC7vGsCdUP00NG8Q8RBiQmNrdSg=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=SIOwzz30I0DxjWK538Yiep0xjnFNtPlOwva12R1ik5n79Ysyu3OY9a5HnAyQckBtv N3u6F7dnWSL/K0hHyBPcvcVF1ECHCvjeIkGq00Rrq4Ty+qBCXKy5oec0yq7lnzP6pB xU3HQe/0y/XWzMJpMRefQ9UaNHBpKucZyYpBUP/E= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x2BCMY6P089908 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 11 Mar 2019 07:22:34 -0500 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 11 Mar 2019 07:22:34 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Mon, 11 Mar 2019 07:22:34 -0500 Received: from [172.22.80.120] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id x2BCMYMg017167; Mon, 11 Mar 2019 07:22:34 -0500 Subject: Re: [PATCH 03/25] dt-bindings: leds: Add LED_FUNCTION definitions To: Jacek Anaszewski , CC: , , , , Baolin Wang , Daniel Mack , Linus Walleij , Oleh Kravchenko , Sakari Ailus , Simon Shields References: <20190310182836.20841-1-jacek.anaszewski@gmail.com> <20190310182836.20841-4-jacek.anaszewski@gmail.com> From: Dan Murphy Message-ID: Date: Mon, 11 Mar 2019 07:22:17 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <20190310182836.20841-4-jacek.anaszewski@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jacek On 3/10/19 1:28 PM, Jacek Anaszewski wrote: > Add common LED function definitions for use in Device Tree. > The function names were extracted from existing dts files > after eliminating oddities. > > Signed-off-by: Jacek Anaszewski > Cc: Baolin Wang > Cc: Daniel Mack > Cc: Dan Murphy > Cc: Linus Walleij > Cc: Oleh Kravchenko > Cc: Sakari Ailus > Cc: Simon Shields > --- > include/dt-bindings/leds/common.h | 38 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h > index e171d0a6beb2..ffcd46317307 100644 > --- a/include/dt-bindings/leds/common.h > +++ b/include/dt-bindings/leds/common.h > @@ -19,4 +19,42 @@ > #define LEDS_BOOST_ADAPTIVE 1 > #define LEDS_BOOST_FIXED 2 > > +/* Standard LED functions */ > +#define LED_FUNCTION_ACTIVITY "activity" > +#define LED_FUNCTION_ADSL "adsl" > +#define LED_FUNCTION_ALARM "alarm" > +#define LED_FUNCTION_BACKLIGHT "backlight" > +#define LED_FUNCTION_BLUETOOTH "bluetooth" > +#define LED_FUNCTION_BOOT "boot" > +#define LED_FUNCTION_CHRG "chrg" Why not spell out charge? > +#define LED_FUNCTION_DEBUG "debug" > +#define LED_FUNCTION_DISK "disk" > +#define LED_FUNCTION_DISK_READ "disk-read" > +#define LED_FUNCTION_DISK_WRITE "disk-write" > +#define LED_FUNCTION_FAULT "fault" > +#define LED_FUNCTION_FLASH "flash" > +#define LED_FUNCTION_HDDERR "hdderr" > +#define LED_FUNCTION_HEARTBEAT "heartbeat" > +#define LED_FUNCTION_INDICATOR "indicator" > +#define LED_FUNCTION_INFO "info" > +#define LED_FUNCTION_INTERNET "internet" LEDs function can be for keyboards and keypads. Keypad for hand held devices #define LED_FUNCTION_KEYBOARD "keyboard" #define LED_FUNCTION_KEYPAD "keypad" > +#define LED_FUNCTION_LAN "lan" > +#define LED_FUNCTION_MMC "mmc" > +#define LED_FUNCTION_NAND "nand" > +#define LED_FUNCTION_ON "on" > +#define LED_FUNCTION_PROGRAMMING "programming" > +#define LED_FUNCTION_PWR "pwr" Same comment as above on chrg > +#define LED_FUNCTION_RX "rx" > +#define LED_FUNCTION_SD "sd" > +#define LED_FUNCTION_SLEEP "sleep" > +#define LED_FUNCTION_STANDBY "standby" > +#define LED_FUNCTION_STATUS "status" > +#define LED_FUNCTION_TORCH "torch" > +#define LED_FUNCTION_TV "tv" > +#define LED_FUNCTION_TX "tx" > +#define LED_FUNCTION_USB "usb" > +#define LED_FUNCTION_WAN "wan" > +#define LED_FUNCTION_WLAN "wlan" > +#define LED_FUNCTION_WPS "wps" > + Dan > #endif /* __DT_BINDINGS_LEDS_H */ > -- ------------------ Dan Murphy