From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 354C314A4D4 for ; Sat, 14 Dec 2024 22:33:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734215596; cv=none; b=QYw5AHfnKw15OAWLhMaI2C3T6NP70pUh+NDNdd+k5nhQ50+qxiXJOEsoqJ9qnR68glxUyk1IeFNAd1sqO+cXc8kLwwONjw+KV56vjGkQX00TXO1uzuaSPRsCkr5XPVjExWD5Pu1aqszhUQ9fDWYdQRFvsfXGwv74iLTu7qXZcNM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734215596; c=relaxed/simple; bh=BlHpWGGf4r4JONh6CygaCzqeXiO/02tsNy6cd3qV3Hw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N4ZWM8Bj4iTTDqzQP6ba247TwsHmkqCj7U86wjtWE5Pua/2FWLFvcwBXbDlmYEsO/RAjaPwgEufaEzpraWNnX4ZCYDRejBkqLLP37nk9NzONjMCeWFVIohijHQ3jPRnMrqo4+4b1c89Cu1xHsS60d7Z5s2Ihubn2Iha87Yv3zqs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fsYB7avh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fsYB7avh" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BEMGuZo028804 for ; Sat, 14 Dec 2024 22:33:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oatQbi3O3tD9RBjaYUsTiiz1j1ogTPu6wPVGCfsPV+4=; b=fsYB7avhBKZ2LSkU W/Q6jPFZLHUQAr4ReInUAdIrmD6MPmSBh985PSaq8rjEmPg9yPNW2pBupBwbmw/d B6grEZypEVZGvvQuqsA06k8QVluZfGYvQLKpR/QlfF+Kx5ODoM1AGCM4mYJvUMXw 4FKMQbCxB76drvyZ1DS687xKxPigXrwZPFSbKY0QnDUVVxFvSaly+WfMJasPT6sL YI7FJrbes7KBQvOJfozXYVjU9qoitx2sni0tj59MaML7lk+ef/1M9iOhBvJhQNGw WJcaWCmZNSI9tCKrgvmVvPBbxBRcMNDOtVt4mY5r+bf4/oq04C792s9+fnfKt9UE SIXd4Q== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43h33u13d8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 14 Dec 2024 22:33:14 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6d8f77bf546so8938616d6.0 for ; Sat, 14 Dec 2024 14:33:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734215593; x=1734820393; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oatQbi3O3tD9RBjaYUsTiiz1j1ogTPu6wPVGCfsPV+4=; b=xGYHsihVIieVQmGM0ss9gUoDHxEDmzDJB2GvbbvBz4oR8iTyw8OIu0aLFIDzIkW/F+ +7vLX5ShG2imzgvkcdz3nI2KgVBJeJoOfrbr7zDlztGl416iWU7scDVfIbqFa9I+SXdp 3dW8A5bF2KavmLJiaCWxT8JRT3/QdigfxvpO7yhp3Ymq3524jz4XrlBvWOyhd2vcV5q9 sXchKInQqnhMS1p4zU3YXWPne652Yd+i9O8WfJcb7yqIC0mWxyHAS9FYp0r4VnTu+TEy 9i52rTSyLf4MGhba718U63gme6/mR9PmyNHTc62VUyNNu00HGWkwCJzUW1GnTBclaxGE 9BUQ== X-Forwarded-Encrypted: i=1; AJvYcCXA542Yxgjsy8AG+TsIJ9mG1C0YnSmgjcvQUeqNwgy+DkLklpKx7HUxazCa4QcZnxp/TQk5LsX8XPlwtPw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0QN3rU5kFDWwI9pgsvnTzWEeU8pgmuQSLlGMdpzFhdy5qS2ia 6n32tbwBZMKFny9qDt2mhJU0clceWyuMkNYvurlM+QW+6sZnlN+SPQF9C7AL5dSFeI6LAHo1+Xs pGwle/egHyes/1RK+0l+9XqoWCl2UMxs/GXjt3b6Zb3BIUThYw110k/+rqnXOdok= X-Gm-Gg: ASbGncsLm96WrZhwHfWDGp7VxYijkMnB8iJijX2erR5tcTvJtrMJv5sDI02PCl8rQJJ G9Ut/0gsimorNNkAzKZOzsXLWo5LGYOh5UySuaTCD13Q4UpbonQ0TIkkeyFfN1hWXArCk7vlj2W SPGcU0euar8nqzHEptTr54csqIikOBAJ6n8gx9+/Fsi2X/9UhMY5SFIXbEALE9lZidvtz50xcVf xsOVNa4R3lx5ZS/pn0pHZ8JQ1OPIkHYgYkVpc8nMI9k4W6Ugw/QN0EEra4no0ywXF+XIXg9H23a U1qkKqkgd2uO4jsb1gT8Q3IrqHs6xQWKLQI= X-Received: by 2002:ac8:5dc7:0:b0:467:885e:2c6e with SMTP id d75a77b69052e-467a573441bmr53093771cf.1.1734215593433; Sat, 14 Dec 2024 14:33:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IENLCVvnwGOg/eVAJIwA38T4KTTRcSsV4U16aVEQULVqYttcjIrmj+Qh4yUFcSMppLXkCVpYA== X-Received: by 2002:ac8:5dc7:0:b0:467:885e:2c6e with SMTP id d75a77b69052e-467a573441bmr53093551cf.1.1734215593099; Sat, 14 Dec 2024 14:33:13 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aab96067de5sm140124066b.55.2024.12.14.14.33.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Dec 2024 14:33:12 -0800 (PST) Message-ID: Date: Sat, 14 Dec 2024 23:33:09 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFT 4/4] arm64: dts: qcom: msm8994: Describe USB interrupts To: Petr Vorel , Konrad Dybcio Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Bjorn Andersson , Yassine Oudjana , Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?B?S3J5xaF0b2YgxIxlcm7DvQ==?= , Alexander Reimelt , Dominik Kobinski , Harry Austen , Konrad Dybcio References: <20241129-topic-qcom_usb_dtb_fixup-v1-0-cba24120c058@oss.qualcomm.com> <20241129-topic-qcom_usb_dtb_fixup-v1-4-cba24120c058@oss.qualcomm.com> <20241206220252.GA138783@pevik> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241206220252.GA138783@pevik> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: teNl6GlPKr8k7ZYV5rJ-4LUb2J0q7W7_ X-Proofpoint-GUID: teNl6GlPKr8k7ZYV5rJ-4LUb2J0q7W7_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 clxscore=1015 malwarescore=0 spamscore=0 priorityscore=1501 suspectscore=0 mlxlogscore=828 bulkscore=0 adultscore=0 mlxscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412140186 On 6.12.2024 11:02 PM, Petr Vorel wrote: > Hi Konrad, all, > >> From: Konrad Dybcio > >> Previously the interrupt lanes were not described, fix that. > >> Fixes: d9be0bc95f25 ("arm64: dts: qcom: msm8994: Add USB support") >> Signed-off-by: Konrad Dybcio >> --- >> arch/arm64/boot/dts/qcom/msm8994.dtsi | 9 +++++++++ >> 1 file changed, 9 insertions(+) > >> diff --git a/arch/arm64/boot/dts/qcom/msm8994.dtsi b/arch/arm64/boot/dts/qcom/msm8994.dtsi >> index 1acb0f159511996db07bc7543cf4f194a4ebd0fa..8c0b1e3a99a767e7c28bcaf3b9687501cc15cd58 100644 >> --- a/arch/arm64/boot/dts/qcom/msm8994.dtsi >> +++ b/arch/arm64/boot/dts/qcom/msm8994.dtsi >> @@ -437,6 +437,15 @@ usb3: usb@f92f8800 { >> #size-cells = <1>; >> ranges; > >> + interrupts = , >> + , >> + , >> + ; >> + interrupt-names = "pwr_event", >> + "qusb2_phy", >> + "hs_phy_irq", >> + "ss_phy_irq"; >> + > > Tested-by: Petr Vorel > > Well, I tested this on msm8994 Huawei Nexus 6P. It did not break anything, > but obviously it's not enough for phone to get USB working. IMHO none of > msm899[24] has working USB. It did work for me on both libra and on the Sony phones.. On the Lumias it worked when I booted through lk2nd, and I tracked it down to one of the writes that I never implemented.. and then I removed the repo where I had it tracked down I took a quick peek (but don't have the time right now to make sure it's this one) and if my memory doesn't fail me, you may need to // the second address in qcom,usb-dwc3-msm in downstream void __iomem *foo = ioremap(0xFD4AB000, 0x4); u32 val = readl(foo); val |= BIT(0); writel(val, foo); > msm8996 has usb3phy, hsusb_phy[12] labels, I suppose USB will not be working > until this is set. Below is a snippet of a downstream device tree. I might > be able to transform it to the mainline tree, but feel free to post a patch > (probably obvious for you). So long as the PHY is not reset, it should be working as well as it did in the bootloader.. which depending on whether your BL set it up may mean "well" or "not at all".. Give the above a shot, put it in some early init code. Konrad