From: Hamza Mahfooz <hamza.mahfooz@amd.com>
To: Qingqing Zhuo <qingqing.zhuo@amd.com>, amd-gfx@lists.freedesktop.org
Cc: Emma Anholt <emma@anholt.net>, David Airlie <airlied@gmail.com>,
Maxime Ripard <mripard@kernel.org>,
Daniel Vetter <daniel@ffwll.ch>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] drm/vc4: Fix build error with undefined label
Date: Wed, 8 Mar 2023 11:11:22 -0500 [thread overview]
Message-ID: <ac8fed53-6f05-6ec7-9ef5-61110cd83c0b@amd.com> (raw)
In-Reply-To: <20230308093408.239331-1-qingqing.zhuo@amd.com>
+ vc4 maintainers
On 3/8/23 04:34, Qingqing Zhuo wrote:
> [Why]
> drivers/gpu/drm/vc4/vc4_hdmi.c: In function ‘vc4_hdmi_bind’:
> drivers/gpu/drm/vc4/vc4_hdmi.c:3448:17: error: label ‘err_disable_runtime_pm’ used but not defined
>
> [How]
> update err_disable_runtime_pm to err_put_runtime_pm.
>
> Signed-off-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index 9e145690c480..edf882360d24 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -3445,7 +3445,7 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data)
> */
> ret = pm_runtime_resume_and_get(dev);
> if (ret)
> - goto err_disable_runtime_pm;
> + goto err_put_runtime_pm;
>
> if ((of_device_is_compatible(dev->of_node, "brcm,bcm2711-hdmi0") ||
> of_device_is_compatible(dev->of_node, "brcm,bcm2711-hdmi1")) &&
--
Hamza
next parent reply other threads:[~2023-03-08 16:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230308093408.239331-1-qingqing.zhuo@amd.com>
2023-03-08 16:11 ` Hamza Mahfooz [this message]
2023-03-08 16:19 ` Maxime Ripard
2023-03-08 16:27 ` Zhuo, Qingqing (Lillian)
2023-03-08 16:32 ` Maxime Ripard
2023-03-08 16:39 ` Alex Deucher
2023-03-08 16:43 ` Zhuo, Qingqing (Lillian)
2023-03-08 16:43 ` Hamza Mahfooz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac8fed53-6f05-6ec7-9ef5-61110cd83c0b@amd.com \
--to=hamza.mahfooz@amd.com \
--cc=airlied@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=qingqing.zhuo@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®