From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "Woojung Huh" <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de,
"Jens Emil Schulz Østergaard"
<jensemil.schulzostergaard@microchip.com>
Subject: Re: [PATCH net-next 3/3] net: dsa: forget the port ageing time when the port leaves the bridge
Date: Fri, 6 Nov 2026 14:30:05 +0100 [thread overview]
Message-ID: <ac9079a2-a197-4572-9771-c04d4bba438f@lunn.ch> (raw)
In-Reply-To: <20261104-ksz-stp-ageing-v1-3-2c2bc7217dea@pengutronix.de>
On Wed, Nov 04, 2026 at 12:48:30PM +0100, Oleksij Rempel wrote:
> A port that leaves the bridge keeps its cached dp->ageing_time, and it
> still counts for dsa_switch_fastest_ageing_time(). A port that leaves
> during an STP topology change keeps the switch at the short value until
> the port joins a bridge again.
>
> Clear the cached value when the port leaves the bridge. The switch is
> not reprogrammed on leave. If the leaving port held the shortest ageing
> time, for example during a topology change, the switch keeps that value
> until the next ageing time change or bridge join in the DSA tree.
Does the software bridge trigger an ageing time change soon
afterwards? Does a port leaving the software bridge trigger a topology
change?
I'm just trying to understand how long the fast ageing value will be
left in place.
Andrew
prev parent reply other threads:[~2026-11-06 13:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 11:48 [PATCH net-next 0/3] net: dsa: make a shorter bridge ageing time take effect Oleksij Rempel
2026-11-04 11:48 ` [PATCH net-next 1/3] net: dsa: microchip: ksz9477: apply a shorter ageing time at once Oleksij Rempel
2026-11-06 13:16 ` Andrew Lunn
2026-11-04 11:48 ` [PATCH net-next 2/3] net: dsa: store the port ageing time before programming it Oleksij Rempel
2026-11-06 13:23 ` Andrew Lunn
2026-11-04 11:48 ` [PATCH net-next 3/3] net: dsa: forget the port ageing time when the port leaves the bridge Oleksij Rempel
2026-11-06 13:30 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac9079a2-a197-4572-9771-c04d4bba438f@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=jensemil.schulzostergaard@microchip.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®