mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: chenqingyun001@208suo.com
To: catalin.marinas@arm.com, will@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] arm64: errata:#include <linux/cpufeature.h> instead of <asm/cpufeature.h>            space required after that ','
Date: Thu, 13 Jul 2023 19:36:49 +0800	[thread overview]
Message-ID: <ac915cdb7b41c38a4af64fec89f9ddee@208suo.com> (raw)
In-Reply-To: <tencent_90950F0CFE28194211015CA269F07BE08C06@qq.com>

The linux/cpufeature.h header file is a more general and
standardized header file, which includes the cpufeature.h
header files under different architectures, while the
asm/cpufeature.h header file is a header file specific
to a certain architecture. There may be some
incompatibilities or outdated issues.
If commas are used to separate multiple parameters
or expressions, there should be a space after the
commas to maintain code readability and style consistency.


Signed-off-by: Qingyun Chen <chenqingyun001@208suo.com>
---
  arch/arm64/kernel/cpu_errata.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/kernel/cpu_errata.c 
b/arch/arm64/kernel/cpu_errata.c
index 307faa2b4395..9b19380629c1 100644
--- a/arch/arm64/kernel/cpu_errata.c
+++ b/arch/arm64/kernel/cpu_errata.c
@@ -10,7 +10,7 @@
  #include <linux/cpu.h>
  #include <asm/cpu.h>
  #include <asm/cputype.h>
-#include <asm/cpufeature.h>
+#include <linux/cpufeature.h>
  #include <asm/kvm_asm.h>
  #include <asm/smp_plat.h>

@@ -726,7 +726,7 @@ const struct arm64_cpu_capabilities arm64_errata[] = 
{
          .capability = ARM64_WORKAROUND_2658417,
          /* Cortex-A510 r0p0 - r1p1 */
          ERRATA_MIDR_RANGE(MIDR_CORTEX_A510, 0, 0, 1, 1),
-        MIDR_FIXED(MIDR_CPU_VAR_REV(1,1), BIT(25)),
+        MIDR_FIXED(MIDR_CPU_VAR_REV(1, 1), BIT(25)),
          .cpu_enable = cpu_clear_bf16_from_user_emulation,
      },
  #endif

           reply	other threads:[~2023-07-13 11:37 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <tencent_90950F0CFE28194211015CA269F07BE08C06@qq.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac915cdb7b41c38a4af64fec89f9ddee@208suo.com \
    --to=chenqingyun001@208suo.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®