From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760034AbcHEPos (ORCPT ); Fri, 5 Aug 2016 11:44:48 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:22291 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753297AbcHEPoq (ORCPT ); Fri, 5 Aug 2016 11:44:46 -0400 X-AuditID: cbfec7f5-f792a6d000001302-5f-57a4b46ace77 Subject: Re: [PATCH v4 1/4] mfd: Add DT bindings documentation for Samsung Exynos LPASS To: Lee Jones References: <1467738785-31410-1-git-send-email-s.nawrocki@samsung.com> <20160805133628.GG5243@dell> Cc: broonie@kernel.org, robh@kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, ideal.song@samsung.com, inki.dae@samsung.com, b.zolnierkie@samsung.com, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Sylwester Nawrocki Message-id: Date: Fri, 05 Aug 2016 17:44:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <20160805133628.GG5243@dell> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOLMWRmVeSWpSXmKPExsVy+t/xK7pZW5aEG7zZqGFx5eIhJouNM9az Wkx9+ITNYv6Rc6wWu/7eZ7SYdH8Ci8X9r0cZLS7vmsNmMeP8PiaL/3t2sDtweWz43MTmsWlV J5vHnWt72Dz6tqxi9Pi8SS6ANYrLJiU1J7MstUjfLoEr48unV2wF76Qqft5fz9zAuF60i5GT Q0LAROJI7ytmCFtM4sK99WxdjFwcQgJLGSVerWlhgnCeM0o87zvA0sXIwSEsEClx4UU+iCki oCJx7o05SK+QQKrE/fc7WUDKmQXeM0qsvP+QBSTBJmAo0Xu0jxHE5hWwk3g34wqYzSKgKnHh 41V2EFtUIELi1qqPUDWCEj8m3wNbxSmgKXG83QrEZBZQl5gyJRekgllAXmLzmrfMExgFZiFp mIVQNQtJ1QJG5lWMoqmlyQXFSem5RnrFibnFpXnpesn5uZsYIcH/dQfj0mNWhxgFOBiVeHgX rFsSLsSaWFZcmXuIUYKDWUmE9+AaoBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHembvehwgJpCeW pGanphakFsFkmTg4pRoYp5w62Tx3c1i5jISz5bedX3ZE7q44vefG54B93D8uqkuzqHDcn7N+ 4gTVDvbso5d+c/pzmJZ43suX37Nuf/kunweG3xm6QlImL05esup89Ly5B8LtEu9ZTGJ7Oe9m kWz96bte12fwnStU/f/A90lJ4tq57odCL6f/2lDu8oLvS3WjilWUyXE9RiWW4oxEQy3mouJE APM2wYF6AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/05/2016 03:36 PM, Lee Jones wrote: > On Tue, 05 Jul 2016, Sylwester Nawrocki wrote: > >> This patch adds documentation of the DT bindings for the Samsung >> Exynos SoC Low Power Audio Subsystem. >> >> Signed-off-by: Sylwester Nawrocki >> new file mode 100644 >> index 0000000..7e97c0d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt >> @@ -0,0 +1,21 @@ >> + > > Nit: This line is superfluous. > >> +Samsung Exynos SoC Low Power Audio Subsystem (LPASS) >> + >> +Required properties: >> + >> + - compatible : "samsung,exynos5433-lpass" >> + - reg : should contain the LPASS top SFR region location and size >> + - samsung,pmu-syscon : the phandle to the Power Management Unit node >> + - #address-cells: should be 1 >> + - #size-cells: should be 1 >> + - ranges: must be present > > These look so much better like: > > - compatible : "samsung,exynos5433-lpass" > - reg : should contain the LPASS top SFR region location and size > - samsung,pmu-syscon : the phandle to the Power Management Unit node > - #address-cells : should be 1 > - #size-cells : should be 1 > - ranges : must be present OK, will rewrite it this way. >> +Each IP block of the Low Power Audio Subsystem should be specified >> +as an optional sub-node. For "samsung,exynos5433-lpass" compatible >> +this includes: UART, SLIMBUS, PCM, I2S, DMAC, Timers 0...4, WDT 0...1 >> +devices. >> + >> +Bindings of the sub-nodes are described in: >> + Documentation/devicetree/bindings/serial/samsung_uart.txt >> + Documentation/devicetree/bindings/sound/samsung-i2s.txt >> + Documentation/devicetree/bindings/dma/arm-pl330.txt > > Use relative path names: > > ../serial/samsung_uart.txt > ../sound/samsung-i2s.txt > ../dma/arm-pl330.txt OK, actually I had it this way in one of the versions but somehow with full paths it appeared better to me. > Missing example? Yes, omitted deliberately as that appeared quite many more lines with fully specified subnodes. Perhaps I will add it with omitted all properties of the subnodes but compatible. audio-subsystem { compatible = "samsung,exynos5433-lpass"; reg = <0x11400000 0x100>, <0x11500000 0x08>; samsung,pmu-syscon = <&pmu_system_controller>; #address-cells = <1>; #size-cells = <1>; ranges; adma: adma@11420000 { compatible = "arm,pl330", "arm,primecell"; reg = <0x11420000 0x1000>; interrupts = <0 73 0>; clocks = <&cmu_aud CLK_ACLK_DMAC>; clock-names = "apb_pclk"; #dma-cells = <1>; #dma-channels = <8>; #dma-requests = <32>; }; i2s0: i2s0@11440000 { compatible = "samsung,exynos7-i2s"; reg = <0x11440000 0x100>; dmas = <&adma 0 &adma 2>; dma-names = "tx", "rx"; interrupts = <0 70 0>; clocks = <&cmu_aud CLK_PCLK_AUD_I2S>, <&cmu_aud CLK_SCLK_AUD_I2S>, <&cmu_aud CLK_SCLK_I2S_BCLK>; clock-names = "iis", "i2s_opclk0", "i2s_opclk1"; pinctrl-names = "default"; pinctrl-0 = <&i2s0_bus>; status = "disabled"; }; serial_3: serial@11460000 { compatible = "samsung,exynos5433-uart"; reg = <0x11460000 0x100>; interrupts = <0 67 0>; clocks = <&cmu_aud CLK_PCLK_AUD_UART>, <&cmu_aud CLK_SCLK_AUD_UART>; clock-names = "uart", "clk_uart_baud0"; pinctrl-names = "default"; pinctrl-0 = <&uart_aud_bus>; status = "disabled"; }; };