From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53DABCA0EC3 for ; Tue, 12 Sep 2023 02:33:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239187AbjILCdd (ORCPT ); Mon, 11 Sep 2023 22:33:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239166AbjILCdQ (ORCPT ); Mon, 11 Sep 2023 22:33:16 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EFEBA018F for ; Mon, 11 Sep 2023 17:06:14 -0700 (PDT) Received: from [192.168.2.112] (109-252-153-31.dynamic.spd-mgts.ru [109.252.153.31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id 9DF3A66072FD; Tue, 12 Sep 2023 00:44:58 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1694475900; bh=WkotUAC8lDAjycWqSJXebM742z0pXxUqQkHS57KhQSQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TkH+MPbx6TY/R6uMAKG41NtKuJONwdQE7fCB1AZDH8nNT0/TvmVbleNAz3h/bxL8B wRsPtGqCMtzo6HPppFPG9S0l/sEZhGwPU/ioIAmCPUWFE8Pvt/WeA2JO3yb1V+HHZJ eWJEBzc3j0XTSATB+o4hwKBuZriHRYgMgwwx/Oq0LzaVuMOjafdVFz9uCrPPx5QHoP yS+nJH0ewVf+CXQGOXcYIcXME1DGvi5amRDYx+4MXoXVUeS7H6SK3thkwDJXTwIGhU qvKW7QanB2V1rbVCcizQIQWiyl97HCLt/OaWYGVtK2v+eIRoH14R6FvXIFz8NjrTzk QzUYVJVi3Xf7w== Message-ID: Date: Tue, 12 Sep 2023 02:44:55 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker Content-Language: en-US To: Dan Carpenter , oe-kbuild@lists.linux.dev, David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , =?UTF-8?Q?Christian_K=c3=b6nig?= , Qiang Yu , Steven Price , Boris Brezillon , Emma Anholt , Melissa Wen Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, kernel@collabora.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org References: <55952e5b-8c55-4888-ba22-eda33525c3b9@kadam.mountain> From: Dmitry Osipenko In-Reply-To: <55952e5b-8c55-4888-ba22-eda33525c3b9@kadam.mountain> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/7/23 13:03, Dan Carpenter wrote: > 2c607edf57db6a Dmitry Osipenko 2023-09-03 @724 if (page_offset >= num_pages || (!shmem->pages && !shmem->evicted)) { > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > Should this be || instead of &&? (The other thing that people do is > add "!shmem->evicted" for readability even though it doesn't need to be > checked. So maybe that's the issue, but the checker assumes it needs to > be checked). > > d611b4a0907cec Neil Roberts 2021-02-23 725 ret = VM_FAULT_SIGBUS; > d611b4a0907cec Neil Roberts 2021-02-23 726 } else { > 2c607edf57db6a Dmitry Osipenko 2023-09-03 727 err = drm_gem_shmem_swapin_locked(shmem); > > Or maybe it's because the kbuild bot can't use the cross function db > and shmem->pages is assigned here? Should be a function db problem. The shmem->pages won't be NULL if drm_gem_shmem_swapin_locked() succeeds. -- Best regards, Dmitry