From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D2BF3793D2 for ; Mon, 23 Mar 2026 08:32:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774254762; cv=none; b=juywqEto7Is+QZOO/AlCXDjq5C6opu1qODUMHSg6rd8Uj4IUdJRYOLIKJaMUrO7dRrqGreyBrd2UhwZfz/5Z0SZDDDqmIGp75RaGGpr1ooDdJKwHw5BcdWbfbmgt8Wwhg6wrtX3YRHDDkCG6pn6d4EvDAQneZXaAf5E7ggHdkEk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774254762; c=relaxed/simple; bh=OM4/8EjqVIC4YfRgUxJxtAfGfU91Jx+od/JJ0lKT8ys=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IAv8GM9VxXTtQ4aoBzf5ttJzMebCkgjGAbWn+PcaaZI5EPst449gaQ0HzGPRrZatEQUwPslsxf6bPdqGcZZWiAXRz67ENy/k3bd5ooC6oA785YxQtg4SEfVw2AtTkL03Yjtzw5AHxcVYNdSIAFvT8kIJusfRNmi+E6jI6gfJva0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cca36gek; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cca36gek" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-486fda2a389so20574535e9.1 for ; Mon, 23 Mar 2026 01:32:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774254759; x=1774859559; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Fr3pV3yyRiJVOwrQfx1saRdyigbk5kS5X76An04qniw=; b=cca36gekC8kcWOc1c3TpI2dT+mm3p6Asxh6IlGNrtAfkEs/Y7WZsQvBf0dV8X7RcNA fMdZ4233lusvKl3bW1aTBZMpO5KTO2sqrt62fcuVsyT2WhGTo9k5PcdT3JdsCyRy+9Aa vAuMTyofkeFrIQSkOjxQfTxNwxeFqSA7ZPPLCCZD+SeeWNRatevYXU61Hp2B3DLg0jkD 82V6FbUR47paASV99V98TT0G4I3fIXOIGJRLhRt6TmN2FnKj23LJyDzrgGDStY4sS+3b YSI/TzNPTeqk6LB2dAGKxonhkTUdy/yiP5Eh+VHw9AVOYJ5o0M6CzMwHbwZbwwH7Vn/J lKng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774254759; x=1774859559; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fr3pV3yyRiJVOwrQfx1saRdyigbk5kS5X76An04qniw=; b=AEP5YSFUW5e5MdduzqvYotMWkiW4JOKYietMBH9ryOnfT4MiUw3m8sS15cojL2ngLf uJ32553z3tJQglf+/fOWpTNzw22uK0tAwB+YtuUfzU5tH0uahgleuKMFGtkJwXXY4OwF QekWS7wsVy4bSs+WM/e8dH0bx8NCNBuARjx/i6IZci4VNProWrq3WPhLxYUv22OPSehh MMHiXk3Y4uplDD/hOxkzZsrKLgJ5Ns/nX1SExvGYYV9ZAZQqFJHATaZP+cLp8oCJdNCE xd3Odz0wtqg0lVUsfU5D/jMwE2wOlffVPzt0hHYj3a1zmjt2ypcknFTgpriUZTtc5cBS I4iA== X-Forwarded-Encrypted: i=1; AJvYcCUtjN9oiR7mSkkb6eEqEgzCE/jHvT3NixYc0JzCdPJJ2jEbhBxeoBhRLRSevhvM2qVRrxnUAFTeOwFSVjo=@vger.kernel.org X-Gm-Message-State: AOJu0YzZAEytXWNG8d3QFb7HWEVLjnaz7GRIxkPh52xuiLYGscqwm4wo mVFe+szo/LZ7Yat1I8basOZ37xpeh8MJD2qIIG3te28Zu/kc+iIr2/xR7eq+KAnGo+wBYzpTrBd W/s+9 X-Gm-Gg: ATEYQzwnMpLxzRkKK8ri7XqETAKgCcxymNEK+tBHHEkaPoJNDshQ0kck7qz5VuODGaJ e8w7cDkv5iWu9QlM8ev1T9JTgVgY5K46INeCqiVVPexxB/mhOqz1VNW3vH3m9QnswGYFdj8hi8V jAdA7miIEgiSQ6YFGWdKqnPo8XHBvwi3HCPROf04AyJLbI36N/gfNlLnTbwn0US1qd14ehsvweh sMHbpsJi3cL2qxf/1Rnymp2C+Rm87IR7ICARznLFbNpqU5I3Qyo9pE/Va1eVO56bbZw51DVaV79 C6kt7AgXUlG+G6qeBVdvEev9MvSWPtnQ1PQB/92Q93l5UuD3RjAFQcE3txzBrR1gKbDF/WUH3I/ z+lwvey/2CxSL4KbnW1OqaNeTqZckLT7nk8eyJWwTeBhSiO6KQMp4TOgpbFw9aMs9JCBL2OiRg/ 4dO+o3c61/18QDZWnOAaYl8CiyV8yb X-Received: by 2002:a05:600c:1e09:b0:485:4526:ee06 with SMTP id 5b1f17b1804b1-486fedfb677mr162420025e9.11.1774254759594; Mon, 23 Mar 2026 01:32:39 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe032a55sm515752485e9.7.2026.03.23.01.32.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 01:32:39 -0700 (PDT) Date: Mon, 23 Mar 2026 11:32:36 +0300 From: Dan Carpenter To: Junrui Luo Cc: Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Yuhao Jiang , stable@vger.kernel.org Subject: Re: [PATCH] staging: sm750fb: fix division by zero in ps_to_hz() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Mar 23, 2026 at 03:31:56PM +0800, Junrui Luo wrote: > ps_to_hz() is called from hw_sm750_crtc_set_mode() without validating > that pixclock is non-zero. A zero pixclock passed via FBIOPUT_VSCREENINFO > causes a division by zero. > > Fix by rejecting zero pixclock in lynxfb_ops_check_var(), consistent > with other framebuffer drivers. > > Fixes: 81dee67e215b ("staging: sm750fb: add sm750 to staging") > Reported-by: Yuhao Jiang > Cc: stable@vger.kernel.org > Signed-off-by: Junrui Luo > --- Seems reasonable. There is no Closes tag. Could we get some more information about how this was found and tested? regards, dan carpenter