From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from casper.infradead.org (casper.infradead.org [90.155.50.34])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id A002923B612
	for <linux-kernel@vger.kernel.org>; Mon, 23 Mar 2026 14:46:53 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1774277216; cv=none; b=rgeisnE3VBSZXDrw2gGP7CKk7vVxLmS1kMo90uElo0B25DFnsxakbvaZbRQZadkMHcbkly/76AXpfEyiAhQ8LOHmJ79DwVYRF5bkiMUdSKO+LV/A3f+bOzCUMD3SzppnjuEDRXf9zNNb7bw88VEWOOls11BqUwAsqa5MCEAU+4E=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1774277216; c=relaxed/simple;
	bh=dZ4P9ITcXoU4JmY9w3jj1xYXkdk2sfXnaM7rZjznWQI=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=WPFBiC/ho2SoYXgNYAJZf11sPt9wT3H8RooFL3ayg5bfjP4z0KimELWU7tu/v/8OOy2u3EQdXTuHc05MXBq38PiI2RUnHz7lWTIyW7vrwem4cuKfLH+A/XEV3msu74z55ahIlSrWnVJoG7Le/bsGGu0sccqfdygrsAM1MyPeCM0=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=JD3PTkjz; arc=none smtp.client-ip=90.155.50.34
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org
Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="JD3PTkjz"
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
	References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description;
	bh=lCjjml3v1WGzDQJPuQzQaQ287NKiUSYjn0KZrOdUMWY=; b=JD3PTkjzwMQzE9JXet3xkeXKgP
	7NNZp/wHKeCuVvw/5q8ytgw1+uJHUNsw0twCVI/TQ7VVRCwHN+B6LLa24NVjem1QnchEj/33cJUBp
	jaP39w7PVsKUPUDEoRYkLX/c93KaDBUJpVGoaUhSWH9G+9UR49WWGHlbTaLndemasfp2eIFmmNOiV
	gTcS4Xk+7gLVkITeZOZ9daPB0es9dJHaGnhqgCWYMuf3CPK6K5rGaldL0uM0aIh3g4wwf9ImAkzU0
	awTFFG38j+MRrce3FgjPnyhaNEK55gj0wEf0Gv/9L3OlArD2TADM5eL+Svy8KjNCZU7pJPCGB7fhG
	ry6ERzfQ==;
Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux))
	id 1w4gYA-0000000CL0G-2kfB;
	Mon, 23 Mar 2026 14:46:38 +0000
Date: Mon, 23 Mar 2026 14:46:38 +0000
From: Matthew Wilcox <willy@infradead.org>
To: Shivank Garg <shivankg@amd.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@kernel.org>, Zi Yan <ziy@nvidia.com>,
	Matthew Brost <matthew.brost@intel.com>,
	Joshua Hahn <joshua.hahnjy@gmail.com>, Rakie Kim <rakie.kim@sk.com>,
	Byungchul Park <byungchul@sk.com>,
	Gregory Price <gourry@gourry.net>,
	Ying Huang <ying.huang@linux.alibaba.com>,
	Alistair Popple <apopple@nvidia.com>, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/migrate: rename PAGE_ migration flags to FOLIO_MF_
Message-ID: <acFSTlF0epHIrA5v@casper.infradead.org>
References: <20260323141935.389232-3-shivankg@amd.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260323141935.389232-3-shivankg@amd.com>

On Mon, Mar 23, 2026 at 02:19:37PM +0000, Shivank Garg wrote:
> +++ b/mm/migrate.c
> @@ -1135,26 +1135,26 @@ static int move_to_new_folio(struct folio *dst, struct folio *src,
>   * This is safe because nobody is using it except us.
>   */
>  enum {
> -	PAGE_WAS_MAPPED = BIT(0),
> -	PAGE_WAS_MLOCKED = BIT(1),
> -	PAGE_OLD_STATES = PAGE_WAS_MAPPED | PAGE_WAS_MLOCKED,
> +	FOLIO_MF_WAS_MAPPED = BIT(0),
> +	FOLIO_MF_WAS_MLOCKED = BIT(1),
> +	FOLIO_MF_OLD_STATES = FOLIO_MF_WAS_MAPPED | FOLIO_MF_WAS_MLOCKED,

what does 'MF' stand for?  i mean, presumably not the pop culture
meaning of MF ...

>  	locked = true;
>  	if (folio_test_mlocked(src))
> -		old_page_state |= PAGE_WAS_MLOCKED;
> +		old_folio_state |= FOLIO_MF_WAS_MLOCKED;

I mean, this doesn't make sense any more.  PAGE_WAS_MLOCKED is a
sentence that means something.  FOLIO_MF_WAS_MLOCKED doesn't ... unless
you imagine Samuel L Jackson saying it ...