From: Keith Busch <kbusch@kernel.org>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/8] nvme: set discard_granularity from NPDG/NPDA
Date: Mon, 23 Mar 2026 12:37:53 -0600 [thread overview]
Message-ID: <acGIgY7TzngPJkxs@kbusch-mbp> (raw)
In-Reply-To: <CADUfDZoRZ9mZC+C9xVaGna=ufr9wzTP-4BNkY2KyEFzpesYRZg@mail.gmail.com>
On Mon, Mar 23, 2026 at 08:29:25AM -0700, Caleb Sander Mateos wrote:
> On Mon, Mar 2, 2026 at 10:54 AM Keith Busch <kbusch@kernel.org> wrote:
> >
> > On Fri, Feb 27, 2026 at 01:23:45PM -0700, Caleb Sander Mateos wrote:
> > > NVMe block devices always report the logical block size for the
> > > discard_granularity queue limit. However, more accurate values may be
> > > available in the NPDG/NPDA fields of the Identify Namespace structure or
> > > the NPDGL/NPDAL fields of the NVM Command Set Specific Identify
> > > Namespace structure. So use these values to compute discard_granularity.
> > >
> > > Also fix the use of the OPTPERF field to better comply with version 2.1
> > > of the NVMe spec.
> > >
> > > Update the target side to report NPDGL and NPDAL as well, in case the
> > > discard granularity doesn't fit in the 16-bit NPDG and NPDA fields.
> >
> > This series looks good to me. I'll queue it up later this week. I just
> > want to get a pull request for my currently way-behind 7.0 nvme commits,
> > then rebase the tree for new stuff.
>
> Hi Keith, I see this series in the nvme-7.1 tree, but it looks like
> you might have accidentally applied v4 instead of v5? I don't see a
> few of the changes I made in response to your comments on the last
> revision.
Oh, thanks for the notice! I'll take a look and fix it up.
prev parent reply other threads:[~2026-03-23 18:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 20:23 Caleb Sander Mateos
2026-02-27 20:23 ` [PATCH v5 1/8] nvme: add preferred I/O size fields to struct nvme_id_ns_nvm Caleb Sander Mateos
2026-02-27 20:23 ` [PATCH v5 2/8] nvme: fold nvme_config_discard() into nvme_update_disk_info() Caleb Sander Mateos
2026-02-27 20:23 ` [PATCH v5 3/8] nvme: update nvme_id_ns OPTPERF constants Caleb Sander Mateos
2026-02-27 20:23 ` [PATCH v5 4/8] nvme: always issue I/O Command Set specific Identify Namespace Caleb Sander Mateos
2026-02-27 20:23 ` [PATCH v5 5/8] nvme: add from0based() helper Caleb Sander Mateos
2026-02-27 20:23 ` [PATCH v5 6/8] nvme: set discard_granularity from NPDG/NPDA Caleb Sander Mateos
2026-02-27 20:23 ` [PATCH v5 7/8] nvmet: use NVME_NS_FEAT_OPTPERF_SHIFT Caleb Sander Mateos
2026-02-27 20:23 ` [PATCH v5 8/8] nvmet: report NPDGL and NPDAL Caleb Sander Mateos
2026-03-02 18:54 ` [PATCH v5 0/8] nvme: set discard_granularity from NPDG/NPDA Keith Busch
2026-03-02 19:04 ` Caleb Sander Mateos
2026-03-23 15:29 ` Caleb Sander Mateos
2026-03-23 18:37 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acGIgY7TzngPJkxs@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=hch@lst.de \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®