From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Ethan Tidmore <ethantidmore06@gmail.com>
Cc: sajal90 <sajal2005gupta@gmail.com>,
gregkh@linuxfoundation.org, s9430939@naver.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: tidy logical continuations in xmit_linux.c
Date: Tue, 24 Mar 2026 13:22:29 +0200 [thread overview]
Message-ID: <acJz9ea7VNnUdY2A@ashevche-desk.local> (raw)
In-Reply-To: <DHAO3ZQ8EPCF.RAJ0TUZ6QEX0@gmail.com>
On Mon, Mar 23, 2026 at 09:47:42PM -0500, Ethan Tidmore wrote:
> On Mon Mar 23, 2026 at 2:15 PM CDT, sajal90 wrote:
...
> You fixed the logical continuation problem but the alignment is still
> wrong. It should be something like:
>
> if (!rtw_mc2u_disable &&
> check_fwstate(pmlmepriv, WIFI_AP_STATE) &&
Why not
if (!rtw_mc2u_disable && check_fwstate(pmlmepriv, WIFI_AP_STATE) &&
?
> (IP_MCAST_MAC(pkt->data) ||
> ICMPV6_MCAST_MAC(pkt->data)) &&
This also can be joined as it's logically a one piece of the conditional.
(IP_MCAST_MAC(pkt->data) || ICMPV6_MCAST_MAC(pkt->data)) &&
> !padapter->registrypriv.wifi_spec) {
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-24 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 19:15 sajal90
2026-03-24 2:47 ` Ethan Tidmore
2026-03-24 11:22 ` Andy Shevchenko [this message]
2026-03-24 11:20 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acJz9ea7VNnUdY2A@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=s9430939@naver.com \
--cc=sajal2005gupta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®