From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C20939B96F for ; Tue, 24 Mar 2026 16:14:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774368844; cv=none; b=hnv3hk48q5DUyNCJrFHHSbi6y+Ha6603qvwSQ2WOb2qNqP2rnzusO9RNT4NCB2UG3nPxBwzk6BC/mDT/MZyCVDtrrqNO8l0Fx+Ahn/XSezYxLodzC2u8gP/5NRlbxqAXkTHDNS5Me/pfVzGvNK205SfxUAUMzEwxU9C2+wcm0js= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774368844; c=relaxed/simple; bh=ws3cbI3XjmlwJFtML83KgrODngSaUWjyLiKjy0onzlI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hvvpbOR3hRLkf39kVKMXR2bWiVr7dBdFa9iftn0mPr33juXdhQQyMzTMpugOrGt688uDzvp5Qf8tpU7JGj6pKIPth+3za2N9fger+3yIzgTG3XBtM92SPAHBS1eQAdbyoYquLKAmAmCgdEtt8WQaLJmHU4nSQZuYoGvtq6xEqv8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oiLks8zt; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oiLks8zt" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-48374014a77so54802185e9.3 for ; Tue, 24 Mar 2026 09:14:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774368842; x=1774973642; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=1EOCRA3uQBc4AWcGvtFcPMpcHJU/iNoWp5grdcgMgRg=; b=oiLks8ztksgqVBuyawsWb7X/3bmMSUl0Xl1iFZjgydvp3Q0aSPrDUgxizbP4U3vnox HYsrs3hAGUdOBhJl3jB+t4eCME30YrYf2UneUXWP8nyZzK7UCmsqMOvuP1xvlc1UtjaJ meoolLAG1CNeZOEndHc4eXODreCF+kQDq9L9+G1rkhPcf9GEk/YwxMSTS82WDfH9QsFr gglxfuXxmrPY4ePPlWD3zsRJZ8SEzRMzI0Hq4ni4d2f4HOIKtT06siOLS6K9ogtAdXl4 L35HHoUD6HkCZidMHpRw0PZb82Zf7KfyNLN+cEM/0ZCrlIVcYY8gfDxv6TbxomyurNE1 /aTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774368842; x=1774973642; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1EOCRA3uQBc4AWcGvtFcPMpcHJU/iNoWp5grdcgMgRg=; b=TKHo6t+q9uGiXUkbws0UBhWvlDutHBwAY7iVxM6v3jJCMXzn5tmQuPDZLsGadvlkML yhJTnjBb0LZvDktoMG5hVwRcttbaxQ9whoc3xS8p4TxD5OcL8yJKoAqUGWIOEeHEREuE Pz0UjLtli9uzbRlELbgm6fR2pVEA8m1PGKLO3Ae0PSFmxh7ghpXzmcJSWNrRQMGSgDko GCpXFRZvuWfKAHbMpkZWPvMfLJhMab7FhFmfAFzGubFUJq3WlhkTeNszKeUu8aGvzBsh BKynCqr9pAGKLr6ZBdr27m8hfLDc884t+O4h/FVdBn/bqjGZufq4rtBFwsbD0xpG84RC KI0w== X-Forwarded-Encrypted: i=1; AJvYcCXCCvthnnJHt9Fjy7XBcWpqFByF2V51xJ5+aj4vNvjjWF2qLY+2ELjfqGFDi9XtBYsfTt2xEgb4zNb+QuQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy51e2nzIOfTY1XjVGdw5XC8ZGdh8MRMKwqfHBQzhYQD70hYUnL cUcCAQAXYjrwIZ3z+laKJL6MfkOVG2VVRbPdffnICf67PhaQdeigfaGV X-Gm-Gg: ATEYQzwJoKQtZ9oXTEOaBQGQXhsBTSqI3Wu7e2Kuob9BHewPxAToUZ5gcHrAWMk4EW/ LEfRUixar73mJzoc0o4lHOTYseHipQFzCr3el3cYl5ASFYuHJWltx6oSQUzmqRSKwXU2RdIEFEd CFMO+OLlNdTtdF6Z9I6arST8MNbxk6FxLaiyxL3THUmH4JOztx5xIwCl98c5xIBb8upwbMbzUpD zNO78YTnVQE55SyAAYI51L9HLXHlwoGAjJluXz9fEQuDPvpQS591xQPc0kYHJkQQGKOUO0Umo9A F0xzoW+K1HrMj5SVl5qDy6R/SIrTRa/AwfNJMAslB7F0HvD1wGZkCLgJBfzz5vqZpDFQsOZLonA 5zhM3qIxN1i4hC8+Z8cpdd3JogYKpwXnyaswBZblvuTH9WlUGEVbRCD9iQoDqOOcVvyFZFF3jpl hBl/OmcoUO8JeKeLR/t2vxohyX3dYa+GOPsZiJdCtIx8EnrLnab+68aw== X-Received: by 2002:a05:600c:34ca:b0:485:3a27:a960 with SMTP id 5b1f17b1804b1-48715f0369fmr5614135e9.0.1774368841765; Tue, 24 Mar 2026 09:14:01 -0700 (PDT) Received: from osama ([41.46.242.53]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4871102369fsm35141365e9.6.2026.03.24.09.13.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 09:14:01 -0700 (PDT) Date: Tue, 24 Mar 2026 17:13:57 +0100 From: Osama Abdelkader To: Will Deacon Cc: Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Catalin Marinas , Kees Cook , Andrew Morton , "Liam R. Howlett" , Jeff Xu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: vdso: fix AArch32 compat init allocation leaks Message-ID: References: <20260323214117.241216-1-osama.abdelkader@gmail.com> <20260324110512-7a00b224-8c48-445b-93f3-dd9b7a07d3cd@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Mar 24, 2026 at 10:14:38AM +0000, Will Deacon wrote: > On Tue, Mar 24, 2026 at 11:09:12AM +0100, Thomas Weißschuh wrote: > > On Tue, Mar 24, 2026 at 09:59:15AM +0000, Will Deacon wrote: > > > On Mon, Mar 23, 2026 at 10:41:16PM +0100, Osama Abdelkader wrote: > > > > aarch32_alloc_vdso_pages() allocates the AA32 vdso pagelist, the compat > > > > sigpage, then the kuser vectors page. If aarch32_alloc_sigpage() or > > > > aarch32_alloc_kuser_vdso_page() fails, earlier allocations were not freed. > > > > > > But why should they be freed? The vectors, sigpage and vdso are > > > independent from one another, so we can limp along with whatever we > > > managed to allocate. I'm not sure how far we'll get, mind, if single > > > page allocations are failing at initcall time... > > > > In the core vDSO datastore we just panic() if the allocation fails. > > (See tip/timers/vdso for the currentl implementation) > > The same should work for the architecture-specific bits. > > I think we should just leave the code as-is tbh unless there's an actual > issue here. > > Will Thanks all for the review. Regards, Osama