From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD7B643147 for ; Wed, 25 Mar 2026 00:27:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774398424; cv=none; b=FIx+/RlM7tONzDqDecrMeJqK0jdx1jEFr3tnHjWMaiKY3EU5ZxP+2qWQ9nJ7vhg5AWocNZkxsajv7fdtlk826M5mij5fxN426qElwC5j9EA1wlc+GYxtZ9VTjXS2EHso7t9/o6mf+ZqPXAn8c20uW4FQJEtAPv8INoBrv12sHRs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774398424; c=relaxed/simple; bh=Y7EVwJ+sjpBixaJ4qN9HZFjajxFcGP8TqgJtgUVGXlE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LPEueJ9vn5HUxLsx6RRLawjxjaxsT9DlDUO3LK6JRlQa9yIkylHnfbL6PgSGzhZeG+eB88hG83cBJUpazekXQDELGDbntxAyYA/pKgVFH/NlVKLTd45ohm2vXbBLGPDlDJkLhwSZMPlpJllRYlTemp7u6OTTwh506Rdn9ya8Wng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bkwk/mKC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bkwk/mKC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2BDCC2BCB1; Wed, 25 Mar 2026 00:27:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774398424; bh=Y7EVwJ+sjpBixaJ4qN9HZFjajxFcGP8TqgJtgUVGXlE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bkwk/mKCdeMGOikDf1qDXBzCadzZC9pJcXzSGUaNb1GwuC70QkhkYVK8eoetKqatZ YVRR51W7BR+DfTKsKQ0UxKmKMmjflq1TXdrS11ejMscD4ohIkxnrB3jE0i9GRDmZZ5 b9lEW3EEOPqd85vDuKy2DbuSrSOtUuFWf8qoyQ1/R67ipI5Qfv/1WQYwIa8CsUOhUw 2klBzcS15H8OWi/m2tol+kepYz77MaXiGCWS5uabYyKPX3Jf/R6N6hdeaDXfY5g9Ft g75Hwsw+7+7kpaIbQB3NAI3pt7FXIx8l1hPV+DiHdBSE6toFYPRiIPFrbLp2XPLtED DHe8AIvR1xiOQ== Date: Wed, 25 Mar 2026 09:27:02 +0900 From: "Harry Yoo (Oracle)" To: "Lorenzo Stoakes (Oracle)" Cc: Qi Zheng , hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, lorenzo.stoakes@oracle.com, ziy@nvidia.com, yosry.ahmed@linux.dev, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, akpm@linux-foundation.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev, bhe@redhat.com, usamaarif642@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qi Zheng Subject: Re: [PATCH 3/3] mm: memcontrol: correct the nr_pages parameter type of mem_cgroup_update_lru_size() Message-ID: References: <2cf06f9faf51900ce6acbb4740fc60355a2842ed.1774342371.git.zhengqi.arch@bytedance.com> <641f8cfa-3a8a-439e-bf03-87af4c49ca2e@lucifer.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <641f8cfa-3a8a-439e-bf03-87af4c49ca2e@lucifer.local> On Tue, Mar 24, 2026 at 12:28:08PM +0000, Lorenzo Stoakes (Oracle) wrote: > On Tue, Mar 24, 2026 at 07:31:29PM +0800, Qi Zheng wrote: > > From: Qi Zheng > > > > The nr_pages parameter of mem_cgroup_update_lru_size() should clearly > > be long instead of int, let's correct it. > > Hmm, but are you ever going to be adding that many pages? I guess technically > correct though. It has been fine as-is, but reparenting changes that. Reparenting in theory could add billions of pages at once! And yeah the commit message could be improved. -- Cheers, Harry / Hyeonggon