From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6482E373C13 for ; Wed, 25 Mar 2026 07:23:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774423383; cv=none; b=M9cQ+lBNQa00lpTVYy6dGmazfYCBarhPesIF4ggQpKCyZAcGbOTL2BjnKu8JA7Du2QEIh5PtnDdapzuwtBLD4PIpD51KK10pwxzaZjmDnwN6+8ZWmF2W4sPCmFkVO5PDSO3lKIK5r0oX+EcFDExKauKzqOCqDgkrxvc0quTpfZk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774423383; c=relaxed/simple; bh=7ipQqte2yZ9MDbN8E5IAsgZVd4f3naqAvh7sc+iSMis=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=h+4K+BVD7h2eq55CDcNd7cr7Ych/iOCIohst8Ud+pTg8zYkGATZyUOMWjvazfXLOHeJnaLbm1Vz5B+UcDX5kAFpGVwECP7CqA95RlnonlaZZpLh+GALtWNib1ARkZUxsYK8UXmhveLxYcdJ0TXP4ZVJzpzwBNvwrNnQgq2EW788= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Gns64N1C; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Gns64N1C" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-48557c8ad47so14424525e9.0 for ; Wed, 25 Mar 2026 00:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774423381; x=1775028181; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QktAvSAbPbJn2FQ5qCNJTp7ZAkBCXrm/IRSUflqLguM=; b=Gns64N1C7DEt8/1Kuuf/GsbOLpEbhTyUJcOEJTRBRHADcG57P27Oj32S0daFLfgPUG tN6NATXDatTzyXIabJu+bJN5yXmbIk8iohS6Is6o5daZNnChivvl35ZneWJZsit+5SVN fog5c7U1BBfK6ZZCEHjCVOxDFzrvU9NiDcjQP80Ce0OZA+CzYm/6mltEsKUllqw0dmI0 rfRSf+dNcYxMfUobNmqeYPBlDZhE1dEwZzX2zTgMyMJKB7R3VU10iA6ATV1GyHNiMhsj 0RRjDfk3FvrUTJYiJsbCNprJDx3ebM9vxg/e02014u60+G1ovG7kh+LXI8HTn9/gaPiW 1V7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774423381; x=1775028181; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QktAvSAbPbJn2FQ5qCNJTp7ZAkBCXrm/IRSUflqLguM=; b=kNIkh2QjtmVwGpgXy/9KsmRgoQt5YTJN7in+mJwlWBN1htbDfDYt5k24gfBsrU/9pU /ExJk8eJlSYPkGJgTWXMvTTAzyOnWQxS66C0vHpnGsvurwDy3bcxny0ddGSTn94W2P8/ I9dozU1E7O7H7CcC6aXO7JEtVD1WxaiwZ5F+2LxJb2JQBamDxsw35HEwo4kRIcvl2X1Y F3EA3Fyp/8v31/2Aqg8tNLowIE/1wc6u7FawdUIn7YH2oyG/M716Rk0m3k0bdqlvgM2z By0X+Aad79yuo4v1idKiksO1upDuIWa2U6JBEOo51k9RDC0fiW+6pEZvRj7FMfE5z1+V 6Rzw== X-Forwarded-Encrypted: i=1; AJvYcCW8v8z9D8FY7+qijxy5hBcsOIdjkQ5txWC032Kiyxsusp5BIXqVjZHgWK2lyi1VWEnM0MrGrb5cfkFQBus=@vger.kernel.org X-Gm-Message-State: AOJu0YybssCfr7KBW9fN4se41bFnhbpLo2f6NvfZawV6WwHtZ5mHkEK9 qT78dOr7tULTAE8Y2uowSC+fIphmMLECF8q4gZiWgaFjFrllKS+0/GDEHM5N4+iHWxk= X-Gm-Gg: ATEYQzwwgqN6b3yFwRAdFfXPWoNguOzek8rpQNej0ALwAPBmuS+jCNMTJQ14Meu08+E 2du2HhOtN7LCRpwm2uL/3Fs7Q9+53S419wPST9eD6+IRHJ/92+ZFlGjfaxaN9rMAOChiy2x8D6+ zsHfyiLR+GMN5ZCpYdXfR2pZ1fBvjUTb716Z1WDuY9lpc1HE6c6eB7NSn5QcT/7DkFmBfKb7SQw dXylQEJ+VYSWBmVYw0ebdLlOaOKUJBpXd76R6El4Hy8nlkoFul0dVD1MR3IFJDtXh5VrEEPVgos th2a2q+TTsfXpyZPVQEVCeGxxctDj71DC5YVY8Q9dfyyjIzlfxekVO5z6+pvtgGPz2iWEeWPL0u PwCK8DVpTTW5P+h81oZWeL7h2WwPMNclpw93MH4mMgsqCy1xGHNVyQCyHTAr5o5ML91akRTWO8I TNAN2UIqt+93nGr25igl9tmh5REtU8 X-Received: by 2002:a05:600c:1e8f:b0:487:36c:f5ab with SMTP id 5b1f17b1804b1-48715fe70f2mr31812345e9.10.1774423380596; Wed, 25 Mar 2026 00:23:00 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48711764625sm112332235e9.14.2026.03.25.00.22.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 00:22:59 -0700 (PDT) Date: Wed, 25 Mar 2026 10:22:56 +0300 From: Dan Carpenter To: Shuah Khan Cc: Prithvi , Andy Shevchenko , gregkh@linuxfoundation.org, abrahamadekunle50@gmail.com, straube.linux@gmail.com, b9788213@gmail.com, ethantidmore06@gmail.com, weibu@redadmin.org, knavaneeth786@gmail.com, ignacio.pena87@gmail.com, dharanitharan725@gmail.com, lukagejak5@gmail.com, samasth.norway.ananda@oracle.com, karanja99erick@gmail.com, s9430939@naver.com, suunj1331@gmail.com, ysinghcin@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, david.hunter.linux@gmail.com, khalid@kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: fix constant on left side of test checkpatch warnings Message-ID: References: <20260323162901.121947-1-activprithvi@gmail.com> <20260324130234.3776tp4ykuerffcg@inspiron> <20260324135551.grth7jfjyoh5krzr@inspiron> <20260324160229.f46h25ebd2mxcfiq@inspiron> <656d3bf5-8d97-454e-9691-540cdb79dab4@linuxfoundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <656d3bf5-8d97-454e-9691-540cdb79dab4@linuxfoundation.org> There are a couple of different things happening here. The mentorship program has its own rules. The rule that people should test their code seems like a good rule. In staging, most of the patches that we apply not tested. I assumed this patch wasn't tested. Patches like this are not a big deal because we can easily review them. Sometimes, patches change runtime so unless it's a security issue, we want those to be tested. > > - if (0x00 == PathAOK) { > - } > We normally wouldn't merge patches which do multiple things at once but it doesn't really make sense to reverse this condition around since it's dead code so to me it falls under the "related change" category. regards, dan carpenter