From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63EE640DFBA; Thu, 26 Mar 2026 00:02:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774483327; cv=none; b=lTffMlxdPEpbjxOCXyI5JflhZzBVvJuKvwAAFSe1QOhemv98wAyFX/XjIQZa1fqMuhgolOuipU7Adl/sx6zJzCOwpM4OQx7ulJN4gYwSh8rz6OXjBFI9Xcea2nVXr4IqHr11CreiR1Epz9FeeYOgJWKTNgHDeHOEaswsVrE3Bd0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774483327; c=relaxed/simple; bh=3xxVnXVbNEeoSMgDa1a5nGKHxLS0wuYpyW49atelE5U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=toOk47++x8FLXQh4RtYv/9oz5xrzbJqjC/LcseVvLFCuLnqR2fM/W26FvfIqa26Q2Q2w2lkYl9CmWMW0zdijVcYgyQOBygyl7f82FI0e7txNYZlG5+C7z4h9PAyreTdua/G8mCMK1Oz1JdchYS6gL+OdQEtn6Alwmoys4Bbl0Wo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=s9/Wx+mV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="s9/Wx+mV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9089C4CEF7; Thu, 26 Mar 2026 00:02:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774483327; bh=3xxVnXVbNEeoSMgDa1a5nGKHxLS0wuYpyW49atelE5U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s9/Wx+mVa3jpWBeu/9tRolQBqtBSNjqUWUAtqfoe98tHKrABo3ph3Cjel449fAouR IqckYRAlH6kmWC6DxlxE6oy4FNcIEtqQhmmhM02zryQkOJ9BgIiS5Wq4CvXbcMSy5D 2cIncXlLKakoTSfQliSq15QRLgbjlg+1K9ykKvDFxXEdn+MujmIpHeBZcLf5jtPkT4 JDTAqZxZOtfpU5Ytv8m93cjt7UhjCT+Z4qOvsJeQ2eVU5kd5Nu3U7rRcXTeYUdRyRo eVYVWdC3j7KyWuJJ/iLBwBHP2pASvKSJwF+fru2ARXvBScwyHzfFP2ZTy8wQeaI7Vi vojSt75pa/wTg== Date: Wed, 25 Mar 2026 14:02:05 -1000 From: Tejun Heo To: Sebastian Andrzej Siewior Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Bert Karwatzki , Michal Koutny , Johannes Weiner , kernel test robot Subject: Re: [PATCH v3 cgroup/for-7.0-fixes] cgroup: Fix cgroup_drain_dying() testing the wrong condition Message-ID: References: <68d8881fd985a410c0f619f009334c28@kernel.org> <20260325180623.EcyNsp2L@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260325180623.EcyNsp2L@linutronix.de> On Wed, Mar 25, 2026 at 07:06:23PM +0100, Sebastian Andrzej Siewior wrote: > On 2026-03-25 07:23:48 [-1000], Tejun Heo wrote: > > cgroup_drain_dying() was using cgroup_is_populated() to test whether there are > > dying tasks to wait for. cgroup_is_populated() tests nr_populated_csets, > > nr_populated_domain_children and nr_populated_threaded_children, but > > cgroup_drain_dying() only needs to care about this cgroup's own tasks - whether > > there are children is cgroup_destroy_locked()'s concern. > … > > Tested-by: Sebastian Andrzej Siewior > > The only issue I see is if I delay the irq_work callback by a second. > Other than that, I don't see any problems. What issue do you see when delaying it by a second? Just things being slowed down? Thanks. -- tejun