From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Gabriel Rondon <grondon@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: adc: ti-ads8688: use read_avail for available attributes
Date: Thu, 26 Mar 2026 10:57:44 +0200 [thread overview]
Message-ID: <acT1CDjDmR6s6iUu@ashevche-desk.local> (raw)
In-Reply-To: <acT0avRL4AZxgjg-@ashevche-desk.local>
On Thu, Mar 26, 2026 at 10:55:06AM +0200, Andy Shevchenko wrote:
> On Wed, Mar 25, 2026 at 11:09:42AM +0000, Gabriel Rondon wrote:
...
> > Changes in v2:
> > - Use -BIT() macro instead of -(1 << ...) to avoid potential UB and
> > improve readability (Andy Shevchenko)
>
> Not really (and LKP showed that), I suggested to use GENMASK().
But it will still cut the value, so you most likely would like to have
GENMASK_U16() or alike.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-26 8:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 11:09 Gabriel Rondon
2026-03-25 19:42 ` kernel test robot
2026-03-25 20:46 ` kernel test robot
2026-03-26 8:55 ` Andy Shevchenko
2026-03-26 8:57 ` Andy Shevchenko [this message]
2026-03-30 18:14 ` grondon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acT1CDjDmR6s6iUu@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=grondon@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®