From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B98A3C5530 for ; Thu, 26 Mar 2026 09:57:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774519075; cv=none; b=cF5gXh9/s6C0crHCu9cSiJDk338hTH04U789qIVss2Acl2ghEMokmUqVgnsrfvNYGFnssP/I+Kd0uiDk7zhBdIqtYQw/sW9jNgvOf0yRZFmXvhW4H0kgtdweWqeKDooDDsAvRXOj5cs+4A67Gup8AbwzEgSz2SjMER8tmMh5V2Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774519075; c=relaxed/simple; bh=+Tuzg7EPJUnKq5cXaBzoX1W1u0lcpN+rgFSvLNoU0YI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=X22BqQRD5dG+lDkHbH4rBXOrViU4+g/O+bz8uRkVWVg6u2Op1+3sG03kKgqxDmMr1F6AnXEfRx55RbL8JtQsj1E8tmYvPk3ID2vkaQlEyaHzVqJ8+MkfCX/J+6E0S5kqNHpsLzW3SyJXjRa4IIpOE/vVBT8Oe4xu9J1caJh+b7A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Rw9dxGMQ; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Rw9dxGMQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774519072; x=1806055072; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+Tuzg7EPJUnKq5cXaBzoX1W1u0lcpN+rgFSvLNoU0YI=; b=Rw9dxGMQX/AsNLj6xlk5aTIG/gDCmLeJXOioHnH5a1OZ8QPldlyecmcn k37bYw9z2Q1o1hx6EOTNTcaSrx8PNY/C4jiVVMNdPLM2A3oORMfHLdM9V T5fA3UeEaX8FnBIEk0WyWQwjRzYicUk/OJ/EMHO7Z2XJwInxWifkLooXw xzjrk25srsv7YLBW9oGdXMbS7HudytXl5y6EBrVEco+t2Rop/G6N9BlNE 8rjiFOUWL9/DHmlBAqtHGDQ0sPRZdlWqv/BE3cqiXinazEAhW6ntwbWI9 ca5HGp8MxXknKp/cAnXI3Jek1m+LVLVhoBS2housUuLGFV+eO8rP5wGiK Q==; X-CSE-ConnectionGUID: CHaUekC0RtSTHvNJDH6eCQ== X-CSE-MsgGUID: h2qh8IZCQO696tbzprINbA== X-IronPort-AV: E=McAfee;i="6800,10657,11740"; a="86190343" X-IronPort-AV: E=Sophos;i="6.23,141,1770624000"; d="scan'208";a="86190343" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2026 02:57:51 -0700 X-CSE-ConnectionGUID: pk5Ev2G8QfCuW+wcqHtgyQ== X-CSE-MsgGUID: KbgTaEr6SV+ZFWWt6NEU0w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,141,1770624000"; d="scan'208";a="255443005" Received: from smoticic-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.216]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2026 02:57:49 -0700 Date: Thu, 26 Mar 2026 11:57:46 +0200 From: Andy Shevchenko To: "Masami Hiramatsu (Google)" Cc: Petr Mladek , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Andrew Morton , David Laight , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/2] lib/vsprintf: Fix to check field_width and precision Message-ID: References: <177444525139.185641.12184379647176430297.stgit@devnote2> <177444526111.185641.13236217811424905684.stgit@devnote2> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <177444526111.185641.13236217811424905684.stgit@devnote2> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Mar 25, 2026 at 10:27:41PM +0900, Masami Hiramatsu (Google) wrote: > Check the field_width and presition correctly. Previously it depends > on the bitfield conversion from int to check out-of-range error. > However, commit 938df695e98d ("vsprintf: associate the format state > with the format pointer") changed those fields to int. > We need to check the out-of-range correctly without bitfield > conversion. ... > +static void > +set_field_width(struct printf_spec *spec, int width) One line. static void set_field_width(struct printf_spec *spec, int width) > +{ > + spec->field_width = clamp(width, -FIELD_WIDTH_MAX, FIELD_WIDTH_MAX); > + WARN_ONCE(spec->field_width != width, "field width %d out of range", > + width); I would also make it one line for readability. WARN_ONCE(spec->field_width != width, "field width %d out of range", width); > +} > + > +static void > +set_precision(struct printf_spec *spec, int prec) One line static void set_precision(struct printf_spec *spec, int prec) > +{ > + spec->precision = clamp(prec, 0, PRECISION_MAX); > + WARN_ONCE(spec->precision < prec, "precision %d too large", prec); > +} -- With Best Regards, Andy Shevchenko