On Thu, Mar 26, 2026 at 11:18:17AM +0100, Krzysztof Kozlowski wrote: > On Wed, Mar 25, 2026 at 09:26:28PM +0000, Chun Ng wrote: > > Add the Tegra238 SoC device tree (tegra238.dtsi) and a minimal device > > tree for the Tegra238 E2426-1099+E2423-1099 engineering reference > > platform. The device-tree is not yet bootable and further enablement > > Then drop it. If this cannot be booted then it is pointless in the > kernel, no benefit, no one can ever use it. The purpose of this series is to establish a common baseline that people can use to work on top off. We expect the non-bootable state to be very temporary, but for practical reasons I want to get this merged so we can make quicker progress. [...] > > + hsp_top0: tegra-hsp@3c00000 { > > + compatible = "nvidia,tegra234-hsp", "nvidia,tegra194-hsp"; > > DTSI says 238, compatible says 234. Tegra238 is a derivative of Tegra234, so there's even more similarities than we typically have across generational gaps. Your recent comments suggested that you'd like to see new compatible strings no matter how minimal (or even non-existent) the differences might be, so I suppose we could prepend a Tegra238-specific compatible to this. Thierry