From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1166D78F4A for ; Fri, 27 Mar 2026 08:03:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774598627; cv=none; b=fxh0EX3FpPDIKz9GN7O/1k8TZ62L2VsAn9DoCi6c2qEp7zRPTkv9+u/HKrfPVqY/Qz4SXmrSpjN3vC7DsvFNdEO6hRbs4x0hpdozdaSkcE9+VggzdbNN6qoLzfxDaAm9GIob5mFV6Naa3S3tx0Tv9stbMP05hZkz6BgjsP7S8vc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774598627; c=relaxed/simple; bh=T1AV/q0So3wtSODTvpImpVvvDR9NsgNQ/yWyR1E89oY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FdkMSLPg5XFyO1jwQPZur0geAAWPt4+tZ60R7STTouqiDCJhih6XfkWC1eRPG+TSJzBJpxgUZJBXy75ybvPIHbyKnmmiGGkUhBsarNB9QZLLVXfklehGdxO25hdaDu5iaSGh0644zwTosPwxiJfSuWXPIWsZf6+IrWOWM+9iWwI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bWGPLzdF; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bWGPLzdF" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-48541edecf9so22395535e9.1 for ; Fri, 27 Mar 2026 01:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774598623; x=1775203423; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=o2vl7BmUaRFbckHv2xt/l3kp6wOvkR8Dj1jivAjEmLU=; b=bWGPLzdFs8ISIHXdSaw7Z4RHMFI0w3k66SZPwDuM83T2jgXU8XtbXS0O08PwwbpdpN dTCwwaF41yaVMROUuCDanzh9zwL8LZeqeU7TiTMPZ5lDadqk3Ud+DxlEmtTRqwSNT+OC 84/wQmQULXrFgfSLo6o7mOyAtZtBE93lk3eMBV6z3aACoaQBXL5dBluDLYJ/mBXfKamr pKTupepD1D1H0xLt2XKi4WsVmkJ1TjuDRydggJvXvyKCISyxxRb7EhSS9D2VZW55dD2T iDJNbt7nZZLRyqQVDjVM9ZOt76ubmP16irJxAjeWPL66urUKrgbeXo90h4o+QPrCB1KV 4wWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774598623; x=1775203423; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o2vl7BmUaRFbckHv2xt/l3kp6wOvkR8Dj1jivAjEmLU=; b=r+tP/1cxIax8Uco9F0IuwaTFSxB8v4DEF2b99EAMWN6HLhQZXNixhuVgrWgeoEPXsB Oz0BRXo2oigWGqUN7jBPeNgVgYBxJ9bI4Fun7QSrhMkNOAlvzRwSo9HKxF5woGcoYLUM cpB6oPZzX/rCoJq6x1m3q63gmzB7N61lz6xA2E703G5KNTVlosvCxTwhKK2DArz+Nc/F x9HYY2BxrJafCjkd4/rPVXHJzRbgevoA/BP8Vf6SYM6Fgssl0r9RhHWg3hnvczW51ZzV gbZvjrD8YymjVupcgVqYKyrjd0JDWnl7Xofx6Jtd+0QDGFa/bQ9b6A299JR5OlrcMME+ Hm/w== X-Forwarded-Encrypted: i=1; AJvYcCXGvDpjGmZTmwtik359VLTLBLJm5O9X8IVEYohmfNKKmm8/m9J7pkbR2fTuBTPFoCVpWlqTY1HSSHf+XB4=@vger.kernel.org X-Gm-Message-State: AOJu0YzkZA15rGFSHAm4/oXLDwpfjuTik+4nkwGBVXm1n6qyoVWXGAEz TDtZDMASC+ZKNRUpds8DalF5qxtuiJq590fUyGtM7WXLTdS3cdA50wU0qho37pC+V3fvGwkFtgn 6eyQJ X-Gm-Gg: ATEYQzwNczzBf+WK/+36xGQ8mrxFYwKevC+R3K0dSfgEbX9/7vCSSNl5ysuUJyodE6b NQymUWwPHdxYugCyck56qW9ijt1uTZFhy5VhnSWctIEpZvEBtfvN2yuvM02t+zjXraZUsHIoMM4 Lpta1wWGbiM/SRiwD42mBls2jlNh1Buv34o+bPcNAUmXDMsro7QV3jC3FusHyLQ04AhCb35esXU eYUkfAjaQYG2e44cfEqBTp1HccIpfpSaNADfZ0sQRbziXw7txqss6cvTR7WZ1XY0JMRPR1kDOp4 4TnNxS1/InoJ8u4E6slzn3f6NJLItfHgp+ayhfipGeFQI8U9ffQQyqi3k66HC22G+IzUAvCtI2s WOmvp+nNi1dDleLp5xtpmk3l/IJcLgT8wC4Xi/aaKp32LCcqQZGwpFL3yzogKXMhe56nSTqPwx8 9m4/r5XjT9zO/kVCzcdKMSD+AvrZUZ X-Received: by 2002:a05:600c:8b86:b0:485:3f58:d9f with SMTP id 5b1f17b1804b1-48727f405fbmr22135135e9.30.1774598622979; Fri, 27 Mar 2026 01:03:42 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-487270dd790sm20927275e9.5.2026.03.27.01.03.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 01:03:42 -0700 (PDT) Date: Fri, 27 Mar 2026 11:03:39 +0300 From: Dan Carpenter To: Ethan Tidmore Cc: MrXploisLite , gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: remove spaces before tabs in hal_com.c Message-ID: References: <20260325235519.36499-1-arokigaming@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Mar 26, 2026 at 01:13:25PM -0500, Ethan Tidmore wrote: > On Wed Mar 25, 2026 at 6:55 PM CDT, MrXploisLite wrote: > > Fix checkpatch warning 'please, no space before tabs' in comment blocks. > > This change removes spaces that precede tab characters in three comment > > lines within the _TwoOutPipeMapping and _ThreeOutPipeMapping functions. > > > > No functional change, only whitespace cleanup to comply with kernel > > coding style. > > > > Signed-off-by: MrXploisLite > > --- > > I believe this has been NACKed in the past. This is just changing > whitespace in a comment, it doesn't really "improve" anything. > Huh. I can't believe you remember conversations from 2 months ago. I had to look it up. I did NAK this patch, but the reason for that is the the alignment is wrong before and after the patch. It should be something like: /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */ /* 0, 1, 0, 1, 0, 0, 0, 0, 0 */ /* 0:ep_0 num, 1:ep_1 num */ So the HCCA column header is over the last zero. Although, looking at it now, we could just delete the comment. I think it was copy and pasted in during development so the author didn't have to switch windows back and forth when they were implementing the code. I don't think it was supposed to be in the released code since it doesn't add any new information. pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[1];/* VO */ The 1 here matches the VO column. ^ ^^ Check that everything is implemented correctly and then just delete these comments. regards, dan carpenter